Page MenuHomePhabricator
Differential D20995

Stop trying to version-check libphutil in "Config"
ClosedPublic
Actions

Authored by epriestley on Feb 14 2020, 4:38 PM.
Tags
None
Referenced Files
F18100880: D20995.diff
Sat, Aug 9, 12:09 PM
F17979512: D20995.id50024.diff
Fri, Aug 1, 6:26 PM
F17955588: D20995.id50023.diff
Fri, Aug 1, 4:53 AM
F17940822: D20995.id.diff
Thu, Jul 31, 4:46 AM
F17934036: D20995.diff
Wed, Jul 30, 9:52 PM
F17881451: D20995.id.diff
Mon, Jul 28, 10:02 PM
F17715888: D20995.id50023.diff
Thu, Jul 17, 3:26 PM
F17707398: D20995.diff
Wed, Jul 16, 2:57 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
Commits
rP4790a3d94be6: Stop trying to version-check libphutil in "Config"
Summary

Ref T13395. No library with this name loads any more, so we can't version check it.

(Ideally, the version check stuff would be more graceful when it fails now, since it's required to load "Config" after I moved it off a separate page.)

Test Plan

Loaded "Config".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2020, 4:38 PM
Harbormaster completed remote builds in B23849: Diff 50023.Feb 14 2020, 4:39 PM
epriestley requested review of this revision.Feb 14 2020, 4:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 4:44 PM
Closed by commit rP4790a3d94be6: Stop trying to version-check libphutil in "Config" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP4790a3d94be6: Stop trying to version-check libphutil in "Config".

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
1 line

Diff 50024

View Options

src/applications/config/controller/PhabricatorConfigConsoleController.php

Loading...
Phabricator · Built by Phacility