Differential D20995

Stop trying to version-check libphutil in "Config"
ClosedPublic
Actions

Authored by epriestley on Feb 14 2020, 4:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 8:42 AM

	Unknown Object (File)
	Sun, Feb 9, 8:42 AM

	Unknown Object (File)
	Sun, Feb 9, 8:42 AM

	Unknown Object (File)
	Tue, Jan 28, 12:18 PM

	Unknown Object (File)
	Tue, Jan 28, 5:27 AM

	Unknown Object (File)
	Sat, Jan 25, 6:37 AM

	Unknown Object (File)
	Sat, Jan 25, 6:37 AM

	Unknown Object (File)
	Sat, Jan 25, 6:37 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rP4790a3d94be6: Stop trying to version-check libphutil in "Config"

Summary

Ref T13395. No library with this name loads any more, so we can't version check it.

(Ideally, the version check stuff would be more graceful when it fails now, since it's required to load "Config" after I moved it off a separate page.)

Test Plan

Loaded "Config".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2020, 4:38 PM

Harbormaster completed remote builds in B23849: Diff 50023.Feb 14 2020, 4:39 PM

epriestley requested review of this revision.Feb 14 2020, 4:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2020, 4:44 PM

Closed by commit rP4790a3d94be6: Stop trying to version-check libphutil in "Config" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4790a3d94be6: Stop trying to version-check libphutil in "Config".

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

controller/

PhabricatorConfigConsoleController.php

1 line

Diff 50024

View Options

src/applications/config/controller/PhabricatorConfigConsoleController.php

Stop trying to version-check libphutil in "Config"ClosedPublicActions