Differential D20977

Continue moving classes with no callers in libphutil or Arcanist to Phabricator
ClosedPublic
Actions

Authored by epriestley on Wed, Feb 12, 8:01 PM.

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator

Summary

Ref T13395. Move cache classes, syntax highlighters, other markup classes, and sprite sheets to Phabricator.

Test Plan

Attempted to find any callers for any of this stuff in libphutil or Arcanist and couldn't.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Bring over the "*.expect" rule in ".arclint".

Harbormaster completed remote builds in B23806: Diff 49980.Wed, Feb 12, 8:03 PM

Harbormaster completed remote builds in B23807: Diff 49981.

epriestley requested review of this revision.Wed, Feb 12, 8:04 PM

Also move the "Pygmentize" parser.

Harbormaster completed remote builds in B23809: Diff 49983.Wed, Feb 12, 8:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Feb 12, 9:14 PM

This revision was landed with ongoing or failed builds.

Closed by commit rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf9b3e3360b0c: Continue moving classes with no callers in libphutil or Arcanist to Phabricator.

Revision Contents
Changeset List

		Path
M		.arclint (4 lines)
M		src/__phutil_library_map__.php (86 lines)
A	M	src/aphront/sprite/PhutilSprite.php (76 lines)
A	M	src/aphront/sprite/PhutilSpriteSheet.php (385 lines)
M		src/applications/differential/parser/DifferentialChangesetParser.php (2 lines)
M		src/applications/files/document/PhabricatorJupyterDocumentEngine.php (4 lines)
A	M	src/infrastructure/cache/PhutilAPCKeyValueCache.php (97 lines)
A	M	src/infrastructure/cache/PhutilDirectoryKeyValueCache.php (244 lines)
A	M	src/infrastructure/cache/PhutilInRequestKeyValueCache.php (118 lines)
A	M	src/infrastructure/cache/PhutilKeyValueCache.php (121 lines)
A	M	src/infrastructure/cache/PhutilKeyValueCacheNamespace.php (65 lines)
A	M	src/infrastructure/cache/PhutilKeyValueCacheProfiler.php (108 lines)
A	M	src/infrastructure/cache/PhutilKeyValueCacheProxy.php (45 lines)
A	M	src/infrastructure/cache/PhutilKeyValueCacheStack.php (131 lines)
A	M	src/infrastructure/cache/PhutilMemcacheKeyValueCache.php (153 lines)
A	M	src/infrastructure/cache/PhutilOnDiskKeyValueCache.php (205 lines)
A	M	src/infrastructure/cache/__tests__/PhutilKeyValueCacheTestCase.php (267 lines)
M		src/infrastructure/diff/PhabricatorDifferenceEngine.php (89 lines)
A	M	src/infrastructure/lipsum/PhutilContextFreeGrammar.php (93 lines)
A	M	src/infrastructure/markup/PhutilMarkupEngine.php (32 lines)
A	M	src/infrastructure/markup/PhutilSafeHTML.php (44 lines)
A	M	src/infrastructure/markup/PhutilSafeHTMLProducerInterface.php (12 lines)
A	M	src/infrastructure/markup/__tests__/PhutilMarkupTestCase.php (223 lines)
A	M	src/infrastructure/markup/__tests__/PhutilSafeHTMLTestCase.php (19 lines)
A	M	src/infrastructure/markup/__tests__/PhutilTranslatedHTMLTestCase.php (68 lines)
A	M	src/infrastructure/markup/render.php (183 lines)
A	M	src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php (115 lines)
A	M	src/infrastructure/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php (19 lines)
A	M	src/infrastructure/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php (28 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php (51 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php (14 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php (81 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php (43 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php (72 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php (229 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php (46 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighter.php (6 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php (18 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/PhutilJSONFragmentLexerHighlighterTestCase.php (24 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/PhutilPHPFragmentLexerHighlighterTestCase.php (25 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php (39 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.expect (12 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.test (12 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.expect (16 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.test (16 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect (5 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.test (5 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.expect (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.test (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.expect (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.test (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect (10 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.source (10 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.source (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.expect (5 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.source (5 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.source (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect (3 lines)
A	M	src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.source (2 lines)
A	M	src/infrastructure/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php (33 lines)
A	M	src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php (262 lines)
A	M	src/infrastructure/parser/PhutilPygmentizeParser.php (83 lines)
A	M	src/infrastructure/parser/__tests__/PhutilPygmentizeParserTestCase.php (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49980	8cc6fe4		Wed, Feb 12, 8:01 PM	★	★
Diff 2	49981	8cc6fe4	- Bring over the "*.expect" rule in ".arclint".	Wed, Feb 12, 8:02 PM	★	★
Diff 3	49983	8cc6fe4	- Also move the "Pygmentize" parser.	Wed, Feb 12, 8:08 PM	★	★
Diff 4	49988	8cc6fe4	rPf9b3e3360b0cef623752a87737001db5f0296c7a	Wed, Feb 12, 9:14 PM	★	★

Diff 49988

View Options

.arclint

View Options

src/__phutil_library_map__.php

View Options

src/aphront/sprite/PhutilSprite.php

View Options

src/aphront/sprite/PhutilSpriteSheet.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php

View Options

src/infrastructure/cache/PhutilDirectoryKeyValueCache.php

View Options

src/infrastructure/cache/PhutilInRequestKeyValueCache.php

View Options

src/infrastructure/cache/PhutilKeyValueCache.php

View Options

src/infrastructure/cache/PhutilKeyValueCacheNamespace.php

View Options

src/infrastructure/cache/PhutilKeyValueCacheProfiler.php

View Options

src/infrastructure/cache/PhutilKeyValueCacheProxy.php

View Options

src/infrastructure/cache/PhutilKeyValueCacheStack.php

View Options

src/infrastructure/cache/PhutilMemcacheKeyValueCache.php

View Options

src/infrastructure/cache/PhutilOnDiskKeyValueCache.php

View Options

src/infrastructure/cache/tests/PhutilKeyValueCacheTestCase.php

View Options

src/infrastructure/diff/PhabricatorDifferenceEngine.php

View Options

src/infrastructure/lipsum/PhutilContextFreeGrammar.php

View Options

src/infrastructure/markup/PhutilMarkupEngine.php

View Options

src/infrastructure/markup/PhutilSafeHTML.php

View Options

src/infrastructure/markup/PhutilSafeHTMLProducerInterface.php

View Options

src/infrastructure/markup/tests/PhutilMarkupTestCase.php

View Options

src/infrastructure/markup/tests/PhutilSafeHTMLTestCase.php

View Options

src/infrastructure/markup/tests/PhutilTranslatedHTMLTestCase.php

View Options

src/infrastructure/markup/render.php

View Options

src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

View Options

src/infrastructure/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

View Options

src/infrastructure/markup/syntax/engine/tests/PhutilDefaultSyntaxHighlighterEngineTestCase.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

View Options

src/infrastructure/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

View Options

src/infrastructure/markup/syntax/highlighter/tests/PhutilJSONFragmentLexerHighlighterTestCase.php

View Options

src/infrastructure/markup/syntax/highlighter/tests/PhutilPHPFragmentLexerHighlighterTestCase.php

View Options

src/infrastructure/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

View Options

src/infrastructure/markup/syntax/highlighter/tests/data/jsonfragment/basics.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/data/jsonfragment/basics.test

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/abuse.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/abuse.test

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/basics.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/basics.test

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.test

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.test

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/builtin-classname.source

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/leading-whitespace.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/leading-whitespace.source

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/multiline-token.source

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.source

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

View Options

src/infrastructure/markup/syntax/highlighter/tests/xhpast/trailing-comment.source

View Options

src/infrastructure/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

View Options

src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

View Options

src/infrastructure/parser/PhutilPygmentizeParser.php

View Options

src/infrastructure/parser/tests/PhutilPygmentizeParserTestCase.php

Continue moving classes with no callers in libphutil or Arcanist to PhabricatorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49988

.arclint

src/__phutil_library_map__.php

src/aphront/sprite/PhutilSprite.php

src/aphront/sprite/PhutilSpriteSheet.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

src/infrastructure/cache/PhutilAPCKeyValueCache.php

src/infrastructure/cache/PhutilDirectoryKeyValueCache.php

src/infrastructure/cache/PhutilInRequestKeyValueCache.php

src/infrastructure/cache/PhutilKeyValueCache.php

src/infrastructure/cache/PhutilKeyValueCacheNamespace.php

src/infrastructure/cache/PhutilKeyValueCacheProfiler.php

src/infrastructure/cache/PhutilKeyValueCacheProxy.php

src/infrastructure/cache/PhutilKeyValueCacheStack.php

src/infrastructure/cache/PhutilMemcacheKeyValueCache.php

src/infrastructure/cache/PhutilOnDiskKeyValueCache.php

src/infrastructure/cache/__tests__/PhutilKeyValueCacheTestCase.php

src/infrastructure/diff/PhabricatorDifferenceEngine.php

src/infrastructure/lipsum/PhutilContextFreeGrammar.php

src/infrastructure/markup/PhutilMarkupEngine.php

src/infrastructure/markup/PhutilSafeHTML.php

src/infrastructure/markup/PhutilSafeHTMLProducerInterface.php

src/infrastructure/markup/__tests__/PhutilMarkupTestCase.php

src/infrastructure/markup/__tests__/PhutilSafeHTMLTestCase.php

src/infrastructure/markup/__tests__/PhutilTranslatedHTMLTestCase.php

src/infrastructure/markup/render.php

src/infrastructure/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

src/infrastructure/markup/syntax/engine/PhutilSyntaxHighlighterEngine.php

src/infrastructure/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php

src/infrastructure/markup/syntax/highlighter/PhutilConsoleSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilDefaultSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilDivinerSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilInvisibleSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilLexerSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilRainbowSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/PhutilSyntaxHighlighterException.php

src/infrastructure/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilJSONFragmentLexerHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilPHPFragmentLexerHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.expect

src/infrastructure/markup/syntax/highlighter/__tests__/data/jsonfragment/basics.test

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.expect

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/abuse.test

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.expect

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/basics.test

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/leading-whitespace.test

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/__tests__/phpfragment/no-leading-whitespace.test

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.expect

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/builtin-classname.source

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/leading-whitespace.source

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.expect

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/multiline-token.source

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/no-leading-whitespace.source

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.expect

src/infrastructure/markup/syntax/highlighter/__tests__/xhpast/trailing-comment.source

src/infrastructure/markup/syntax/highlighter/pygments/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php

src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

src/infrastructure/parser/PhutilPygmentizeParser.php

src/infrastructure/parser/__tests__/PhutilPygmentizeParserTestCase.php

Continue moving classes with no callers in libphutil or Arcanist to Phabricator
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/cache/tests/PhutilKeyValueCacheTestCase.php

src/infrastructure/markup/tests/PhutilMarkupTestCase.php

src/infrastructure/markup/tests/PhutilSafeHTMLTestCase.php

src/infrastructure/markup/tests/PhutilTranslatedHTMLTestCase.php

src/infrastructure/markup/syntax/engine/tests/PhutilDefaultSyntaxHighlighterEngineTestCase.php

src/infrastructure/markup/syntax/highlighter/tests/PhutilJSONFragmentLexerHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/tests/PhutilPHPFragmentLexerHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

src/infrastructure/markup/syntax/highlighter/tests/data/jsonfragment/basics.expect

src/infrastructure/markup/syntax/highlighter/tests/data/jsonfragment/basics.test

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/abuse.expect

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/abuse.test

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/basics.expect

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/basics.test

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/leading-whitespace.test

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/tests/phpfragment/no-leading-whitespace.test

src/infrastructure/markup/syntax/highlighter/tests/xhpast/builtin-classname.expect

src/infrastructure/markup/syntax/highlighter/tests/xhpast/builtin-classname.source

src/infrastructure/markup/syntax/highlighter/tests/xhpast/leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/tests/xhpast/leading-whitespace.source

src/infrastructure/markup/syntax/highlighter/tests/xhpast/multiline-token.expect

src/infrastructure/markup/syntax/highlighter/tests/xhpast/multiline-token.source

src/infrastructure/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.expect

src/infrastructure/markup/syntax/highlighter/tests/xhpast/no-leading-whitespace.source

src/infrastructure/markup/syntax/highlighter/tests/xhpast/trailing-comment.expect

src/infrastructure/markup/syntax/highlighter/tests/xhpast/trailing-comment.source

src/infrastructure/parser/tests/PhutilPygmentizeParserTestCase.php