Page MenuHomePhabricator

Support Perforce/Git repositories in "arc land"
ClosedPublic

Authored by epriestley on Mon, Oct 28, 5:40 PM.

Details

Summary

Ref T13434. Detect perforce remotes and use "git p4" commands in place of "git" commands when operating in Perforce mode.

Test Plan
  • Landed "master" onto itself, saw master update.
  • Landed "feature1" onto clean "master", saw master update.
  • Landed "feature2" onto dirty "master", saw master stay dirty.
  • Landed with "--hold", got sensible submit instructions.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Oct 28, 5:40 PM
epriestley requested review of this revision.Mon, Oct 28, 5:40 PM
epriestley updated this revision to Diff 49748.Mon, Oct 28, 5:52 PM
  • Fix an issue with the non-dirty flow introduced when making the dirty flow work.
  • Ran "arc land" end-to-end in a normal topic branch workflow.
  • Ran "arc land" end-to-end in a normal topic branch workflow with a dirty target branch.
  • Ran "arc land" end-to-end in a no-topic-branch workflow.
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Oct 28, 6:25 PM
This revision was automatically updated to reflect the committed changes.