Differential D20868

Support Perforce/Git repositories in "arc land"
ClosedPublic
Actions

Authored by epriestley on Oct 28 2019, 5:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 8:19 AM

	Unknown Object (File)
	Sun, Feb 9, 8:19 AM

	Unknown Object (File)
	Sun, Feb 9, 8:19 AM

	Unknown Object (File)
	Sun, Feb 9, 8:19 AM

	Unknown Object (File)
	Sun, Feb 9, 8:19 AM

	Unknown Object (File)
	Sat, Jan 25, 5:59 AM

	Unknown Object (File)
	Sat, Jan 25, 5:59 AM

	Unknown Object (File)
	Sat, Jan 25, 5:59 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13434: Support Perforce/Git in "arc land"
Commits: rARCca66743905fb: Support Perforce/Git repositories in "arc land"

Summary

Ref T13434. Detect perforce remotes and use "git p4" commands in place of "git" commands when operating in Perforce mode.

Test Plan

Landed "master" onto itself, saw master update.
Landed "feature1" onto clean "master", saw master update.
Landed "feature2" onto dirty "master", saw master stay dirty.
Landed with "--hold", got sensible submit instructions.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 28 2019, 5:40 PM

Harbormaster completed remote builds in B23576: Diff 49747.Oct 28 2019, 5:40 PM

epriestley requested review of this revision.Oct 28 2019, 5:40 PM

Fix an issue with the non-dirty flow introduced when making the dirty flow work.
Ran "arc land" end-to-end in a normal topic branch workflow.
Ran "arc land" end-to-end in a normal topic branch workflow with a dirty target branch.
Ran "arc land" end-to-end in a no-topic-branch workflow.

Harbormaster completed remote builds in B23577: Diff 49748.Oct 28 2019, 5:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2019, 6:25 PM

Closed by commit rARCca66743905fb: Support Perforce/Git repositories in "arc land" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCca66743905fb: Support Perforce/Git repositories in "arc land".

Revision Contents
Changeset List

Path

Size

src/

land/

ArcanistGitLandEngine.php

284 lines

repository/

api/

ArcanistGitAPI.php

27 lines

workflow/

ArcanistLandWorkflow.php

8 lines

Diff 49752

src/land/ArcanistGitLandEngine.php

Loading...

src/repository/api/ArcanistGitAPI.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...