Page MenuHomePhabricator
Differential D20827

When non-administrators click "Change Username", explain why they can't continue
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 5:41 PM.

Details

Reviewers
None
Maniphest Tasks
T13420: Update "Change Username" to make it more friendly for non-administrators
Commits
rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue
Summary

Ref T13420. This workflow currently dead-ends for non-administrators. Instead, provide explanatory text.

Test Plan
  • Clicked "Change Username" as an administrator, same workflow as always.
  • Clicked "Change Username" as a non-administrator, got explanatory text.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 24 2019, 5:41 PM
epriestley requested review of this revision.Sep 24 2019, 5:43 PM
epriestley edited the test plan for this revision. (Show Details)Sep 24 2019, 5:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:08 PM
Closed by commit rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0c331458a88b: When non-administrators click "Change Username", explain why they can't continue.

Revision Contents
Changeset List

Diff 49657

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
Phabricator · Built by Phacility