Differential D20824

", not just immediate children
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 4:40 PM.

Tags

None

Referenced Files

	F15338568: D20824.id.diff
	Sun, Mar 9, 11:30 AM

	F15338003: D20824.id49647.diff
	Sun, Mar 9, 8:48 AM

	F15333129: D20824.id.diff
	Sat, Mar 8, 12:11 AM

	Unknown Object (File)
	Thu, Feb 27, 5:25 PM

	Unknown Object (File)
	Jan 28 2025, 10:16 PM

	Unknown Object (File)
	Jan 28 2025, 3:22 PM

	Unknown Object (File)
	Jan 21 2025, 11:42 PM

	Unknown Object (File)
	Jan 21 2025, 4:00 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map
Commits: rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children

Summary

Fixes T13418. This test ignores files in any directory named "extensions/", but the intent is to ignore all descendants of "src/extensions/".

Test Plan

Put files in "src/extensions/xyz/QQQ.php", ran "arc liberate", got a clean library map without the class in "QQQ.php" indexed.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 24 2019, 4:40 PM

Harbormaster completed remote builds in B23474: Diff 49647.Sep 24 2019, 4:41 PM

epriestley requested review of this revision.Sep 24 2019, 4:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 5:02 PM

Closed by commit rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilLibraryMapBuilder.php

7 lines

Diff 49648

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Ignore all files in "src/extensions/", not just immediate childrenClosedPublicActions