Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once
ClosedPublic

Authored by epriestley on Sep 3 2019, 5:41 PM.
Tags
None
Referenced Files
F12852991: D20777.id.diff
Fri, Mar 29, 7:58 AM
F12845100: D20777.id49542.diff
Fri, Mar 29, 12:03 AM
Unknown Object (File)
Feb 21 2024, 3:44 AM
Unknown Object (File)
Feb 14 2024, 6:11 AM
Unknown Object (File)
Jan 5 2024, 1:28 PM
Unknown Object (File)
Dec 28 2023, 6:46 PM
Unknown Object (File)
Dec 22 2023, 9:29 PM
Unknown Object (File)
Dec 16 2023, 11:45 PM
Subscribers
None

Details

Summary

Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable