Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once

Authored by epriestley on Sep 3 2019, 5:41 PM.



Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 3 2019, 5:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 5:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.