Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once
ClosedPublic

Authored by epriestley on Sep 3 2019, 5:41 PM.
Tags
None
Referenced Files
F19909931: D20777.diff
Thu, Apr 2, 3:20 AM
F19692040: D20777.id.diff
Feb 10 2026, 4:29 AM
F19569698: D20777.id49542.diff
Feb 1 2026, 12:20 AM
F19569697: D20777.id49542.diff
Feb 1 2026, 12:20 AM
F19508621: D20777.diff
Jan 10 2026, 7:43 AM
F19044841: D20777.id.diff
Nov 27 2025, 4:49 AM
F19040019: D20777.diff
Nov 26 2025, 10:35 AM
F18897882: D20777.diff
Nov 7 2025, 5:47 PM
Subscribers
None

Details

Summary

Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable