Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once
ClosedPublic

Authored by epriestley on Sep 3 2019, 5:41 PM.
Tags
None
Referenced Files
F17317607: D20777.id49543.diff
Thu, Jun 26, 4:32 PM
Unknown Object (File)
Thu, Jun 5, 4:40 PM
Unknown Object (File)
Fri, May 30, 4:38 PM
Unknown Object (File)
May 14 2025, 1:46 AM
Unknown Object (File)
May 5 2025, 3:28 PM
Unknown Object (File)
Apr 26 2025, 5:52 PM
Unknown Object (File)
Apr 22 2025, 2:24 PM
Unknown Object (File)
Apr 18 2025, 5:21 AM
Subscribers
None

Details

Summary

Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable