Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once
ClosedPublic

Authored by epriestley on Sep 3 2019, 5:41 PM.
Tags
None
Referenced Files
F14846508: D20777.id49542.diff
Mon, Feb 3, 4:02 AM
Unknown Object (File)
Sat, Jan 25, 5:38 AM
Unknown Object (File)
Sat, Jan 25, 5:38 AM
Unknown Object (File)
Sat, Jan 25, 5:38 AM
Unknown Object (File)
Thu, Jan 23, 12:46 AM
Unknown Object (File)
Tue, Jan 21, 10:24 AM
Unknown Object (File)
Fri, Jan 17, 7:59 PM
Unknown Object (File)
Fri, Jan 17, 3:12 PM
Subscribers
None

Details

Summary

Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable