Page MenuHomePhabricator

Instead of retrying safe reads 3 times, retry each eligible service once
ClosedPublic

Authored by epriestley on Sep 3 2019, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 19, 6:43 PM
Unknown Object (File)
Apr 18 2026, 8:59 PM
Unknown Object (File)
Apr 14 2026, 11:08 AM
Unknown Object (File)
Apr 2 2026, 3:20 AM
Unknown Object (File)
Feb 10 2026, 4:29 AM
Unknown Object (File)
Feb 1 2026, 12:20 AM
Unknown Object (File)
Feb 1 2026, 12:20 AM
Unknown Object (File)
Jan 10 2026, 7:43 AM
Subscribers
None

Details

Summary

Ref T13286. When retrying a read request, keep retrying as long as we have canididate services. Since we consume a service with each attempt, there's no real reason to abort early, and trying every service allows reads to always succeed even if (for example) 8 nodes of a 16-node cluster are dead because of a severed network link between datacenters.

Test Plan

Ran git pull in a clustered repository with an up node and a down node; saw retry count dynamically adjust to available node count.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable