Page MenuHomePhabricator
Differential D19306

Disable default syntax highlighting for large files in DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 3:13 PM.
Tags
None
Referenced Files
F15465400: D19306.diff
Wed, Apr 2, 6:13 PM
F15461565: D19306.id46205.diff
Tue, Apr 1, 9:17 AM
F15460832: D19306.id46196.diff
Tue, Apr 1, 2:46 AM
F15455105: D19306.id46205.diff
Sat, Mar 29, 10:14 PM
F15453318: D19306.id46196.diff
Sat, Mar 29, 10:53 AM
F15448457: D19306.id.diff
Fri, Mar 28, 5:01 AM
F15438871: D19306.id.diff
Wed, Mar 26, 4:13 AM
F15435903: D19306.diff
Tue, Mar 25, 10:49 AM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP0363febeb2c6: Disable default syntax highlighting for large files in DocumentEngine
Summary

Ref T13105. See also T7895. When users render very large files as source via DocumentEngine, skip highlighting.

Test Plan

Fiddled with the limit, viewed files, saw highlighting degrade.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
files/
document/
21 lines

Diff 46205

View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
Phabricator · Built by Phacility