Page MenuHomePhabricator

Move Diffusion browse rendering to DocumentEngine, breaking almost all features
ClosedPublic

Authored by epriestley on Apr 5 2018, 6:40 PM.

Details

Summary

Ref T13105. This breaks about 9,000 features but moves Diffusion to DocumentEngine for rendering. See T13105 for a more complete list of all the broken stuff.

But you can't bake a software without breaking all the features every time you make a change, right?

Test Plan

Viewed various files in Diffusion, used DocumentEngine features like highlighting and rendering engine selection.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 5 2018, 6:40 PM
epriestley requested review of this revision.Apr 5 2018, 6:41 PM

When people realize what will be capable they won't worry about about the 9,000 features

mydeveloperday accepted this revision.EditedApr 6 2018, 7:52 AM

If I understand correctly this commit moves that old "Browse in Diffusion" to use the DocumentRenderEngine, so it will use the source code with syntax highlighting that you added last week. I guess we lose blame (for now) as one of those 9000 applications, but gain the ability for different file types to select alternative renders.. sweet!.. "breaking eggs and making omelettes and all that!"

This revision is now accepted and ready to land.Apr 6 2018, 7:52 AM
mydeveloperday added inline comments.Apr 6 2018, 7:56 AM
src/applications/diffusion/controller/DiffusionBrowseController.php
187

Nit: I think you don't need this else

This revision was automatically updated to reflect the committed changes.