Page MenuHomePhabricator

When a revision has more than 7 reviewers, render only the first 7 in the list view
ClosedPublic

Authored by epriestley on Apr 3 2018, 6:51 PM.
Tags
None
Referenced Files
F19048449: D19293.id.diff
Nov 27 2025, 2:49 PM
F19038344: D19293.diff
Nov 26 2025, 4:04 AM
F19005149: D19293.id46174.diff
Nov 21 2025, 2:19 PM
F18947028: D19293.diff
Nov 11 2025, 9:17 PM
F18831757: D19293.id.diff
Oct 25 2025, 3:07 PM
F18828585: D19293.diff
Oct 24 2025, 5:12 PM
F18826453: D19293.diff
Oct 24 2025, 4:03 AM
F18654299: D19293.id46174.diff
Sep 22 2025, 5:58 AM
Subscribers
None

Details

Summary

See PHI489. Ref T13110. At least for now, this just shows "..." at the end since you can click the revision to see the whole list anyway.

Also remove the older-style external Handle passing in favor of lazy construction via HandlePool.

Test Plan

Viewed revisions, fiddled with the 7 limit, got sensible-seeming "..." behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 7:47 PM
This revision was automatically updated to reflect the committed changes.