Return a integer JSON type from "*.edit" endpoints for the object ID
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 2:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 6:50 PM

	Unknown Object (File)
	Sun, Dec 1, 6:58 AM

	Unknown Object (File)
	Wed, Nov 27, 10:09 AM

	Unknown Object (File)
	Nov 26 2024, 9:46 AM

	Unknown Object (File)
	Nov 19 2024, 1:01 PM

	Unknown Object (File)
	Nov 3 2024, 9:13 AM

	Unknown Object (File)
	Oct 21 2024, 12:34 PM

	Unknown Object (File)
	Oct 21 2024, 12:06 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID

Summary

See PHI425. See T12678. This should be an integer, but may be a string.

Test Plan

Called differential.revision.edit, observed integer in result instead of string.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 7 2018, 2:22 PM

Harbormaster completed remote builds in B19768: Diff 45953.Mar 7 2018, 2:23 PM

epriestley requested review of this revision.Mar 7 2018, 2:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 2:27 PM

Closed by commit rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

2 lines

Diff 45954

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Return a integer JSON type from "*.edit" endpoints for the object IDClosedPublicActions