Return a integer JSON type from "*.edit" endpoints for the object ID
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 2:22 PM.

Tags

None

Referenced Files

	F15467111: D19186.id.diff
	Thu, Apr 3, 12:50 PM

	F15445857: D19186.id45954.diff
	Thu, Mar 27, 4:13 PM

	F15432154: D19186.diff
	Mon, Mar 24, 4:31 PM

	Unknown Object (File)
	Feb 21 2025, 3:34 PM

	Unknown Object (File)
	Feb 9 2025, 5:38 AM

	Unknown Object (File)
	Feb 9 2025, 5:38 AM

	Unknown Object (File)
	Feb 9 2025, 5:38 AM

	Unknown Object (File)
	Jan 29 2025, 10:42 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID

Summary

See PHI425. See T12678. This should be an integer, but may be a string.

Test Plan

Called differential.revision.edit, observed integer in result instead of string.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 7 2018, 2:22 PM

Harbormaster completed remote builds in B19768: Diff 45953.Mar 7 2018, 2:23 PM

epriestley requested review of this revision.Mar 7 2018, 2:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 2:27 PM

Closed by commit rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

2 lines

Diff 45954

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Return a integer JSON type from "*.edit" endpoints for the object IDClosedPublicActions