Page MenuHomePhabricator

Perform a client-side redirect after OAuth server authorization
ClosedPublic

Authored by epriestley on Mar 6 2018, 6:31 PM.
Tags
None
Referenced Files
F15508094: D19177.id.diff
Wed, Apr 16, 1:30 AM
F15468562: D19177.id45937.diff
Fri, Apr 4, 2:18 AM
F15458177: D19177.id45937.diff
Sun, Mar 30, 9:28 PM
F15456156: D19177.id45935.diff
Sun, Mar 30, 7:23 AM
F15453957: D19177.id.diff
Sat, Mar 29, 3:20 PM
F15451496: D19177.diff
Fri, Mar 28, 10:24 PM
F15447659: D19177.id45937.diff
Fri, Mar 28, 12:51 AM
F15447658: D19177.id45935.diff
Fri, Mar 28, 12:51 AM
Subscribers
None

Details

Summary

Ref T13099. See that task for discussion. Chrome is unhappy with an MFA form submitting to an endpoint which redirects you to an OAuth URI.

Instead, do the redirect entirely on the client.

Chrome's rationale here isn't obvious, so we may be able to revert this at some point.

Test Plan

Went through the OAuth flow locally, was redirected on the client. Will verify in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.