Differential D19172

Don't emit Content-Security-Policy when returning a response during preflight setup checks
ClosedPublic
Actions

Authored by epriestley on Mar 5 2018, 2:52 PM.

Details

Reviewers: None
Maniphest Tasks: T4340: Implement Content-Security-Policy and Strict-Transport-Security headers
Commits: rPe43f2e0cee09: (stable) Don't emit Content-Security-Policy when returning a response during…
rPf31975f7a3be: Don't emit Content-Security-Policy when returning a response during preflight…

Summary

Ref T4340. See https://discourse.phabricator-community.org/t/core-exception-during-installation/1193/8.

If we return a response very early during setup, we may not be able to read from the environment yet. Just decline to build a "Content-Security-Policy" header in these cases.

Test Plan

Faked a preflight error (e.g., safe_mode enabled), restarted apache.
- Before patch: environment error while generating CSP.
- After patch: no error.
Loaded a normal page, observed an normal CSP header.