Page MenuHomePhabricator

Show lint messages in deleted files on the left-hand side of the change
ClosedPublic

Authored by epriestley on Mar 3 2018, 1:28 AM.
Tags
None
Referenced Files
F15417119: D19171.id45924.diff
Thu, Mar 20, 3:30 PM
F15413493: D19171.diff
Wed, Mar 19, 7:10 PM
F15395718: D19171.id.diff
Sun, Mar 16, 9:15 AM
Unknown Object (File)
Feb 18 2025, 10:09 AM
Unknown Object (File)
Feb 13 2025, 2:53 AM
Unknown Object (File)
Feb 9 2025, 3:39 AM
Unknown Object (File)
Feb 7 2025, 3:26 AM
Unknown Object (File)
Feb 6 2025, 3:39 AM
Subscribers
None

Details

Summary

See PHI416. If you raise a lint message in a deleted file, we don't render any text on the right hand side so the message never displays.

This is occasionally still legitimate/useful, e.g. to display a "don't delete this file" message. At least for now, show these messages on the left.

Test Plan

Posted a lint message on a deleted file via harbormaster.sendmessage, viewed revision, saw file expand with synthetic inline for lint.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.