Show lint messages in deleted files on the left-hand side of the change
ClosedPublic
Actions

Authored by epriestley on Mar 3 2018, 1:28 AM.

Details

Reviewers: None
Commits: rP584495215301: Show lint messages in deleted files on the left-hand side of the change

Summary

See PHI416. If you raise a lint message in a deleted file, we don't render any text on the right hand side so the message never displays.

This is occasionally still legitimate/useful, e.g. to display a "don't delete this file" message. At least for now, show these messages on the left.

Test Plan

Posted a lint message on a deleted file via harbormaster.sendmessage, viewed revision, saw file expand with synthetic inline for lint.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Mar 3 2018, 1:29 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2018, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

differential/

controller/

16 lines