Page MenuHomePhabricator

Don't require project edit permission to create a project with members other than yourself
ClosedPublic

Authored by epriestley on Mar 2 2018, 2:41 AM.
Tags
None
Referenced Files
F15492075: D19169.diff
Sat, Apr 12, 10:41 AM
F15465134: D19169.diff
Wed, Apr 2, 3:04 PM
F15441326: D19169.id45917.diff
Wed, Mar 26, 5:35 PM
F15430697: D19169.diff
Mon, Mar 24, 8:36 AM
F15425873: D19169.id45916.diff
Sun, Mar 23, 6:31 AM
F15386010: D19169.id45917.diff
Fri, Mar 14, 11:51 PM
F15284573: D19169.diff
Mar 4 2025, 10:03 AM
Unknown Object (File)
Feb 28 2025, 3:41 AM
Subscribers
None

Details

Summary

See PHI193. Previously, see similar D18763. Skip this legacy-style policy check when creating a project, since we know you can add members, even if the policy doesn't actually resolve in your favor.

Test Plan
  • Created a project with edit policy "Members of project" and myself, plus any other user (so the code goes down this path, not the "join/leave" path) as members.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 2:46 AM
This revision was automatically updated to reflect the committed changes.