Correct flipped transaction constants in "Closed Date" migration
ClosedPublic
Actions

Authored by epriestley on Feb 10 2018, 2:10 PM.

Tags

None

Referenced Files

	F18906896: D19054.diff
	Sat, Nov 8, 8:57 PM

	F18904682: D19054.id.diff
	Sat, Nov 8, 10:32 AM

	F18900136: D19054.diff
	Fri, Nov 7, 8:33 PM

	F18831450: D19054.id45682.diff
	Oct 25 2025, 1:11 PM

	F18756304: D19054.id.diff
	Oct 5 2025, 10:44 AM

	F18756032: D19054.id45681.diff
	Oct 5 2025, 8:50 AM

	F18753868: D19054.diff
	Oct 4 2025, 8:35 PM

	F18736331: D19054.id.diff
	Oct 1 2025, 5:28 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP215b8b4727aa: (stable) Correct flipped transaction constants in "Closed Date" migration
rPffc5c95c2f3d: Correct flipped transaction constants in "Closed Date" migration

Summary

These transaction constants are flipped, which can produce the wrong result in some cases.

Test Plan

./bin/storage upgrade -f --apply phabricator:20180208.maniphest.02.populate.php

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 10 2018, 2:10 PM

Harbormaster completed remote builds in B19482: Diff 45681.Feb 10 2018, 2:10 PM

This revision was not accepted when it landed; it landed in state Draft.Feb 10 2018, 2:11 PM

Closed by commit rPffc5c95c2f3d: Correct flipped transaction constants in "Closed Date" migration (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B19482: Diff 45681.Feb 10 2018, 2:12 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180208.maniphest.02.populate.php

4 lines

Diff 45682

View Options

resources/sql/autopatches/20180208.maniphest.02.populate.php

Correct flipped transaction constants in "Closed Date" migrationClosedPublicActions