Unprototype the Ferret UI fields
ClosedPublic
Actions

Authored by epriestley on Sep 11 2017, 11:29 PM.

Tags

None

Referenced Files

	F18737424: D18587.id.diff
	Wed, Oct 1, 10:38 AM

	F18657400: D18587.id44638.diff
	Tue, Sep 23, 1:39 AM

	F18650621: D18587.id44638.diff
	Sun, Sep 21, 1:17 AM

	F18603456: D18587.id44638.diff
	Sat, Sep 13, 5:12 PM

	F18591059: D18587.diff
	Fri, Sep 12, 8:08 AM

	F18588707: D18587.id44638.diff
	Fri, Sep 12, 1:15 AM

	F18587516: D18587.id44632.diff
	Thu, Sep 11, 9:38 PM

	F18587491: D18587.id.diff
	Thu, Sep 11, 9:35 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size

Commits

rP6edf98eb3b8a: Unprototype the Ferret UI fields

Summary

Ref T12819. Show the new Ferret engine fields (and enable the indexer) unconditionally.

Also pull them to the top since they're fairly general-purpose and appear more broadly now, and also they actually work correctly (WOW).

Some redundant fields (like "Name Contains" in Repositories and Owners) could probably be removed now, I may clean those up in a followup.

Test Plan

Browsed around, saw Ferret fields in UI without "(Prototype)" suffix.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 11 2017, 11:29 PM

Harbormaster completed remote builds in B18415: Diff 44632.Sep 11 2017, 11:30 PM

chad accepted this revision.Sep 12 2017, 12:13 AM

This revision is now accepted and ready to land.Sep 12 2017, 12:13 AM

Closed by commit rP6edf98eb3b8a: Unprototype the Ferret UI fields (authored by epriestley). · Explain WhySep 12 2017, 1:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorApplicationSearchEngine.php

3 lines

engineextension/

PhabricatorFerretSearchEngineExtension.php

4 lines

Diff 44638

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php