Page MenuHomePhabricator

Remove "Contains Words" constraint from Maniphest
ClosedPublic

Authored by epriestley on Sep 11 2017, 11:21 PM.
Tags
None
Referenced Files
F18737616: D18586.id44631.diff
Wed, Oct 1, 11:39 AM
F18709868: D18586.id.diff
Mon, Sep 29, 1:07 AM
F18708672: D18586.id.diff
Sun, Sep 28, 10:21 PM
F18702734: D18586.diff
Sun, Sep 28, 1:15 AM
F18693990: D18586.id44637.diff
Sat, Sep 27, 2:15 AM
F18659645: D18586.diff
Tue, Sep 23, 2:22 PM
F18652511: D18586.diff
Sun, Sep 21, 8:19 AM
F18650246: D18586.id44637.diff
Sun, Sep 21, 12:01 AM
Subscribers
None

Details

Summary

Ref T12819. Obsoleted by the Ferret engine, which is unprototyping shortly.

This breaks compatibility in two ways:

  • maniphest.query no longer supports "fullText" (now throws an explicit exception).
  • Existing saved searches with a "Contains Words" constraint will no longer have that constraint.

It seems unlikely (?) that either of these are seeing too much use, and they should be easy to fix. I'll note them in the changelog.

Test Plan

Viewed Maniphest, no more "Contains Words" field. Called maniphest.query with "fullText", got explicit exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 12 2017, 12:13 AM
This revision was automatically updated to reflect the committed changes.