Page MenuHomePhabricator

Remove some redundant information from the Ferret engine index
ClosedPublic

Authored by epriestley on Sep 8 2017, 3:16 PM.

Details

Summary

Ref T12819. The "full" field has all other fields, and the "core" field has "title" and "body". Due to the way the "full" and "core" fields were being built, the "core" field also got included in the "full" field, so the "full" field has two copies of the title, two copies of the body, and then one copy of everything else.

Put only one copy of each distinct thing in each "full" and "core". Also, simplify the logic a little bit so we build these virtual fields in a more consistent way.

Test Plan

Ran bin/search index and looked at the fields in the database, saw less redundant information.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 8 2017, 3:16 PM
Harbormaster completed remote builds in B18398: Diff 44617.
chad accepted this revision.Sep 8 2017, 4:08 PM
This revision is now accepted and ready to land.Sep 8 2017, 4:08 PM
This revision was automatically updated to reflect the committed changes.