Page MenuHomePhabricator

Use the Ferret engine fulltext document table to drive auxiliary fulltext constraints

Authored by epriestley on Sep 7 2017, 3:49 PM.
Referenced Files
Unknown Object (File)
Tue, May 30, 1:50 AM
Unknown Object (File)
Sun, May 28, 6:22 PM
Unknown Object (File)
Tue, May 23, 7:31 PM
Unknown Object (File)
Sat, May 13, 9:25 AM
Unknown Object (File)
May 2 2023, 2:31 PM
Unknown Object (File)
Apr 29 2023, 2:04 AM
Unknown Object (File)
Apr 27 2023, 8:45 PM
Unknown Object (File)
Apr 25 2023, 1:03 PM



Ref T12819. I started trying to get individual engines to drive these constraints (e.g., ManiphestTaskQuery can do most of the work) but this is a big pain, especially since most engines don't support "any owner" or "no owner", and not everything has an owner, and so on and so on. Going down this path would have meant a huge pile of stub functions everywhere, I think.

Instead, drive these through the main engine using the fulltext document table, which already has everything we need to apply these constraints in a uniform way.

Also tweak some parts of query construction and result ordering.

Test Plan

Searched for documents by author, owner, unowned, any owner, tags, subscribers, fulltext in global search. Got sensible results without any application-specific code.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable