Page MenuHomePhabricator

Use the Ferret engine fulltext document table to drive auxiliary fulltext constraints
ClosedPublic

Authored by epriestley on Sep 7 2017, 3:49 PM.
Tags
None
Referenced Files
F18180193: D18550.id44557.diff
Sat, Aug 16, 5:43 AM
F18107708: D18550.id44586.diff
Mon, Aug 11, 2:31 AM
F17978368: D18550.diff
Fri, Aug 1, 6:01 PM
F17947430: D18550.id.diff
Thu, Jul 31, 4:33 PM
F17927657: D18550.diff
Wed, Jul 30, 2:58 PM
F17818835: D18550.id.diff
Jul 26 2025, 12:42 AM
F17760184: D18550.diff
Jul 22 2025, 7:19 PM
Unknown Object (File)
Jul 4 2025, 4:10 PM
Subscribers
None

Details

Summary

Ref T12819. I started trying to get individual engines to drive these constraints (e.g., ManiphestTaskQuery can do most of the work) but this is a big pain, especially since most engines don't support "any owner" or "no owner", and not everything has an owner, and so on and so on. Going down this path would have meant a huge pile of stub functions everywhere, I think.

Instead, drive these through the main engine using the fulltext document table, which already has everything we need to apply these constraints in a uniform way.

Also tweak some parts of query construction and result ordering.

Test Plan

Searched for documents by author, owner, unowned, any owner, tags, subscribers, fulltext in global search. Got sensible results without any application-specific code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable