Page MenuHomePhabricator

Use the Ferret engine fulltext document table to drive auxiliary fulltext constraints
ClosedPublic

Authored by epriestley on Sep 7 2017, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 22, 11:38 PM
Unknown Object (File)
Fri, Jul 19, 1:39 AM
Unknown Object (File)
Thu, Jul 18, 8:27 PM
Unknown Object (File)
Mon, Jul 15, 10:09 AM
Unknown Object (File)
Fri, Jul 12, 1:55 PM
Unknown Object (File)
Wed, Jun 26, 11:26 AM
Unknown Object (File)
Mon, Jun 24, 2:01 PM
Unknown Object (File)
Jun 23 2024, 5:00 AM
Subscribers
None

Details

Summary

Ref T12819. I started trying to get individual engines to drive these constraints (e.g., ManiphestTaskQuery can do most of the work) but this is a big pain, especially since most engines don't support "any owner" or "no owner", and not everything has an owner, and so on and so on. Going down this path would have meant a huge pile of stub functions everywhere, I think.

Instead, drive these through the main engine using the fulltext document table, which already has everything we need to apply these constraints in a uniform way.

Also tweak some parts of query construction and result ordering.

Test Plan

Searched for documents by author, owner, unowned, any owner, tags, subscribers, fulltext in global search. Got sensible results without any application-specific code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable