Page MenuHomePhabricator

Don't set a default "group by priority" in the task search engine
ClosedPublic

Authored by epriestley on Aug 24 2017, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 7:47 PM
Unknown Object (File)
Mon, Apr 15, 10:39 PM
Unknown Object (File)
Wed, Apr 10, 5:45 PM
Unknown Object (File)
Mon, Apr 8, 5:55 AM
Unknown Object (File)
Wed, Apr 3, 3:43 PM
Unknown Object (File)
Mar 29 2024, 1:34 PM
Unknown Object (File)
Mar 24 2024, 5:49 AM
Unknown Object (File)
Mar 10 2024, 7:48 PM
Subscribers
None

Details

Summary

See PHI42. Currently, maniphest.search incorrectly applies this default (group by priority) to all queries via Conduit.

The correct behavior is to apply no grouping constraint.

I think this is also a reasonable general behavior, and the current code seems to date from D6960 in 2013 and didn't seem particularly carefully considered.

This is a minor compatibility break -- saved queries which are more than 4 years old might change their group behavior. I'll note this in the change logs but expect essentially no one to be affected.

Test Plan

Ran a maniphest.search Conduit call and observed the underlying query. Before this change, it executed ORDER BY priority, id. After this change, it correctly executed ORDER BY id only.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable