Page MenuHomePhabricator

Don't set a default "group by priority" in the task search engine
ClosedPublic

Authored by epriestley on Aug 24 2017, 1:03 PM.
Tags
None
Referenced Files
F18819313: D18459.id.diff
Wed, Oct 22, 5:38 AM
F18788277: D18459.id44356.diff
Wed, Oct 15, 4:01 AM
F18784143: D18459.id44347.diff
Mon, Oct 13, 11:58 AM
F18612875: D18459.diff
Sep 14 2025, 10:00 AM
F18350026: D18459.id.diff
Aug 26 2025, 7:06 PM
F18340048: D18459.diff
Aug 25 2025, 9:55 PM
F18103731: D18459.id44356.diff
Aug 10 2025, 7:30 AM
F18103041: D18459.id44347.diff
Aug 10 2025, 1:17 AM
Subscribers
None

Details

Summary

See PHI42. Currently, maniphest.search incorrectly applies this default (group by priority) to all queries via Conduit.

The correct behavior is to apply no grouping constraint.

I think this is also a reasonable general behavior, and the current code seems to date from D6960 in 2013 and didn't seem particularly carefully considered.

This is a minor compatibility break -- saved queries which are more than 4 years old might change their group behavior. I'll note this in the change logs but expect essentially no one to be affected.

Test Plan

Ran a maniphest.search Conduit call and observed the underlying query. Before this change, it executed ORDER BY priority, id. After this change, it correctly executed ORDER BY id only.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable