Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
F15459947: D18458.id44346.diff
Mon, Mar 31, 6:36 PM
F15459946: D18458.id44344.diff
Mon, Mar 31, 6:36 PM
F15458500: D18458.diff
Mon, Mar 31, 4:06 AM
F15417958: D18458.id44344.diff
Thu, Mar 20, 7:43 PM
F15416689: D18458.diff
Thu, Mar 20, 12:59 PM
F15409533: D18458.diff
Wed, Mar 19, 4:40 AM
F15392902: D18458.id44344.diff
Sat, Mar 15, 6:20 PM
F15379456: D18458.diff
Thu, Mar 13, 9:17 PM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable