Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
F18562722: D18458.id44344.diff
Tue, Sep 9, 4:29 AM
F18100168: D18458.id.diff
Aug 9 2025, 11:32 AM
F18098207: D18458.id44344.diff
Aug 8 2025, 7:11 PM
F18098138: D18458.id44346.diff
Aug 8 2025, 7:02 PM
F18093892: D18458.diff
Aug 7 2025, 9:12 PM
F18092040: D18458.id44344.diff
Aug 7 2025, 4:16 AM
F18087581: D18458.id44344.diff
Aug 6 2025, 4:34 AM
F18052137: D18458.diff
Aug 4 2025, 1:29 AM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable