Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
F13147678: D18458.diff
Fri, May 3, 3:23 PM
Unknown Object (File)
Mon, Apr 15, 3:32 PM
Unknown Object (File)
Mon, Apr 15, 3:32 PM
Unknown Object (File)
Mon, Apr 15, 6:59 AM
Unknown Object (File)
Mon, Apr 15, 3:46 AM
Unknown Object (File)
Mon, Apr 8, 8:22 AM
Unknown Object (File)
Mon, Apr 8, 1:29 AM
Unknown Object (File)
Mar 4 2024, 3:08 AM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable