Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 12:31 PM
Unknown Object (File)
Jun 9 2026, 11:47 AM
Unknown Object (File)
Apr 5 2026, 12:18 PM
Unknown Object (File)
Feb 11 2026, 11:38 PM
Unknown Object (File)
Feb 11 2026, 11:38 PM
Unknown Object (File)
Feb 7 2026, 12:03 AM
Unknown Object (File)
Jan 13 2026, 7:48 PM
Unknown Object (File)
Nov 1 2025, 9:12 AM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable