Don't select disabled menu items as default
ClosedPublic
Actions

Authored by chad on Aug 23 2017, 4:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:15 AM

	Unknown Object (File)
	Mon, Apr 15, 5:43 AM

	Unknown Object (File)
	Wed, Apr 10, 8:59 PM

	Unknown Object (File)
	Wed, Apr 10, 6:11 PM

	Unknown Object (File)
	Mon, Apr 8, 5:01 PM

	Unknown Object (File)
	Mon, Apr 8, 5:01 PM

	Unknown Object (File)
	Mon, Apr 8, 2:25 PM

	Unknown Object (File)
	Mon, Apr 8, 2:24 PM

View All 70 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12969: Disabled "Home" dashboard still shown by default if in 1st menu position

Commits

rP748725a47d38: Don't select disabled menu items as default

Summary

Fixes T12969. If you disable "Home" but leave it at the top, we still load it.

Test Plan

Disabled "Home". Move Dashboard into first position, see correct home layout.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 23 2017, 4:39 PM

Harbormaster completed remote builds in B18125: Diff 44336.Aug 23 2017, 4:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 23 2017, 4:39 PM

epriestley accepted this revision.Aug 23 2017, 4:39 PM

This revision is now accepted and ready to land.Aug 23 2017, 4:39 PM

Harbormaster completed remote builds in B18125: Diff 44336.Aug 23 2017, 4:40 PM

Closed by commit rP748725a47d38: Don't select disabled menu items as default (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 23 2017, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

2 lines

Diff 44337

View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Don't select disabled menu items as defaultClosedPublicActions