Page MenuHomePhabricator

Make all revision status readers explicitly read modern or legacy status
ClosedPublic

Authored by epriestley on Aug 11 2017, 11:23 PM.
Tags
None
Referenced Files
F15419712: D18417.id.diff
Fri, Mar 21, 8:16 AM
F15397049: D18417.diff
Sun, Mar 16, 5:49 PM
F15377896: D18417.id44252.diff
Thu, Mar 13, 11:22 AM
F15299504: D18417.diff
Wed, Mar 5, 3:16 PM
Unknown Object (File)
Jan 23 2025, 10:16 AM
Unknown Object (File)
Jan 21 2025, 9:25 AM
Unknown Object (File)
Jan 17 2025, 10:34 PM
Unknown Object (File)
Jan 1 2025, 9:42 PM
Subscribers
None

Details

Summary

Ref T2543. All writers now write modern statuses. Make all readers explicit about whether they are reading modern or legacy statuses, so I can swap the storage format.

Test Plan
  • Grepped for getStatus(), scanned the list. Other applications have methods with this name so it's possible I missed something.
  • Browed around, changed revision statuses.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable