Page MenuHomePhabricator
Differential D18396

Remove legacy `withStatus()` method from RevisionQuery
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:32 PM.
Tags
None
Referenced Files
F18761695: D18396.id.diff
Mon, Oct 6, 3:46 PM
F18715556: D18396.id.diff
Mon, Sep 29, 10:26 AM
F18707565: D18396.diff
Sun, Sep 28, 8:02 PM
F18706200: D18396.id44211.diff
Sun, Sep 28, 3:58 PM
F18705069: D18396.diff
Sun, Sep 28, 9:55 AM
F18614137: D18396.diff
Sun, Sep 14, 12:06 PM
F18508989: D18396.id.diff
Sep 5 2025, 3:08 AM
F18501394: D18396.diff
Sep 4 2025, 9:43 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP13ddb15bbcfb: Remove legacy `withStatus()` method from RevisionQuery
Summary

Ref T2543. All callsites are now in terms of withStatuses().

Test Plan
  • Called differential.query and differential.find from Conduit API.
  • Grepped through all withStatus() callsites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 11 2017, 4:32 PM
Harbormaster completed remote builds in B18009: Diff 44211.Aug 11 2017, 4:34 PM
chad accepted this revision.Aug 11 2017, 5:13 PM
This revision is now accepted and ready to land.Aug 11 2017, 5:13 PM
Closed by commit rP13ddb15bbcfb: Remove legacy `withStatus()` method from RevisionQuery (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
4 lines
5 lines
constants/
4 lines
query/
32 lines

Diff 44238

View Options

src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php

Loading...
View Options

src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php

Loading...
View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
Phabricator · Built by Phacility