Page MenuHomePhabricator

Allow '0' as a valid subheader in PHUIActionPanelView
AbandonedPublic

Authored by chad on Aug 9 2017, 9:36 PM.
Tags
None
Referenced Files
F15412728: D18377.id.diff
Wed, Mar 19, 2:37 PM
F15392172: D18377.diff
Sat, Mar 15, 1:37 PM
Unknown Object (File)
Jan 12 2025, 4:03 AM
Unknown Object (File)
Dec 31 2024, 5:16 PM
Unknown Object (File)
Dec 28 2024, 12:19 PM
Unknown Object (File)
Dec 16 2024, 3:50 PM
Unknown Object (File)
Nov 29 2024, 4:33 AM
Unknown Object (File)
Nov 26 2024, 7:05 PM
Subscribers

Details

Reviewers
epriestley
Summary

Good ole strlen

Test Plan

Set subheader to 0 and see actual text.

Diff Detail

Repository
rP Phabricator
Branch
strlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17967
Build 24124: Run Core Tests
Build 24123: arc lint + arc unit

Event Timeline

This will break if there are currently any callsites which pass a tag (e.g. phutil_tag()) or view to setHeader() or setSubheader(). Your test plan should make some effort to verify that there aren't unless you're sure about this without further verification.

This revision is now accepted and ready to land.Aug 9 2017, 10:34 PM