Page MenuHomePhabricator

Allow '0' as a valid subheader in PHUIActionPanelView
AbandonedPublic

Authored by chad on Aug 9 2017, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 6:27 AM
Unknown Object (File)
Mon, Mar 18, 2:18 AM
Unknown Object (File)
Dec 9 2023, 7:08 AM
Unknown Object (File)
Dec 3 2023, 8:09 PM
Unknown Object (File)
Nov 30 2023, 6:29 AM
Unknown Object (File)
Nov 19 2023, 2:41 PM
Unknown Object (File)
Oct 15 2023, 2:32 AM
Unknown Object (File)
Sep 20 2023, 9:08 AM
Subscribers

Details

Reviewers
epriestley
Summary

Good ole strlen

Test Plan

Set subheader to 0 and see actual text.

Diff Detail

Repository
rP Phabricator
Branch
strlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17967
Build 24124: Run Core Tests
Build 24123: arc lint + arc unit

Event Timeline

This will break if there are currently any callsites which pass a tag (e.g. phutil_tag()) or view to setHeader() or setSubheader(). Your test plan should make some effort to verify that there aren't unless you're sure about this without further verification.

This revision is now accepted and ready to land.Aug 9 2017, 10:34 PM