Page MenuHomePhabricator

Allow '0' as a valid subheader in PHUIActionPanelView
AbandonedPublic

Authored by chad on Aug 9 2017, 9:36 PM.
Tags
None
Referenced Files
F15527582: D18377.diff
Tue, Apr 22, 4:51 AM
F15492001: D18377.id44168.diff
Sat, Apr 12, 9:42 AM
F15478734: D18377.id44168.diff
Tue, Apr 8, 2:29 AM
F15473085: D18377.id.diff
Sat, Apr 5, 7:28 PM
F15472272: D18377.id44168.diff
Sat, Apr 5, 12:20 PM
F15469878: D18377.diff
Fri, Apr 4, 5:40 PM
F15412728: D18377.id.diff
Mar 19 2025, 2:37 PM
F15392172: D18377.diff
Mar 15 2025, 1:37 PM
Subscribers

Details

Reviewers
epriestley
Summary

Good ole strlen

Test Plan

Set subheader to 0 and see actual text.

Diff Detail

Repository
rP Phabricator
Branch
strlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17967
Build 24124: Run Core Tests
Build 24123: arc lint + arc unit

Event Timeline

This will break if there are currently any callsites which pass a tag (e.g. phutil_tag()) or view to setHeader() or setSubheader(). Your test plan should make some effort to verify that there aren't unless you're sure about this without further verification.

This revision is now accepted and ready to land.Aug 9 2017, 10:34 PM