Page MenuHomePhabricator
Differential D18336

Switch fluid to fixed on PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Aug 4 2017, 2:51 AM.
Tags
None
Referenced Files
F19469798: D18336.diff
Mon, Jan 5, 4:11 AM
F19303153: D18336.id.diff
Tue, Dec 23, 6:50 PM
F19303108: D18336.id44086.diff
Tue, Dec 23, 6:12 PM
F19292275: D18336.id44087.diff
Tue, Dec 23, 9:35 AM
F19271656: D18336.diff
Mon, Dec 22, 10:52 PM
F18840933: D18336.diff
Oct 28 2025, 5:12 AM
F18838234: D18336.id.diff
Oct 27 2025, 9:48 AM
F18823811: D18336.diff
Oct 23 2025, 1:27 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP68ab9b2642b8: Switch fluid to fixed on PHUITwoColumnView
Summary

We don't ever set fluid, since it already is fluid, also no CSS. Add an actual fixed version.

Test Plan

For use in Instances.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Aug 4 2017, 2:51 AM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2017, 2:51 AM
Harbormaster completed remote builds in B17903: Diff 44086.Aug 4 2017, 2:52 AM
epriestley accepted this revision.Aug 4 2017, 2:53 AM
This revision is now accepted and ready to land.Aug 4 2017, 2:53 AM
Closed by commit rP68ab9b2642b8: Switch fluid to fixed on PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyAug 4 2017, 2:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 44087

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility