Page MenuHomePhabricator

Treat commit hook execution in observed repositories as a no-op, not an error
ClosedPublic

Authored by epriestley on Jul 31 2017, 8:24 PM.
Tags
None
Referenced Files
F15477672: D18307.diff
Mon, Apr 7, 5:16 PM
F15435036: D18307.diff
Tue, Mar 25, 6:35 AM
F15396689: D18307.diff
Sun, Mar 16, 3:50 PM
F15369883: D18307.id44015.diff
Wed, Mar 12, 8:35 AM
Unknown Object (File)
Feb 2 2025, 7:50 AM
Unknown Object (File)
Jan 31 2025, 9:05 PM
Unknown Object (File)
Jan 31 2025, 1:45 AM
Unknown Object (File)
Jan 3 2025, 3:16 AM
Subscribers
None

Details

Summary

See PHI24. If you create a hosted Mercurial repository and switch it to observed, you can end up with a hook installed that runs on pulls and complains.

Instead, just bail out if we're running on a pull.

The corresponding Git hook doesn't run on pulls, so there's no issue in Git.

Test Plan

Executed the hook in an observed Mercurial repository, got a clean exit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable