Page MenuHomePhabricator

Treat commit hook execution in observed repositories as a no-op, not an error
ClosedPublic

Authored by epriestley on Jul 31 2017, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:04 AM
Unknown Object (File)
Nov 17 2024, 9:53 AM
Unknown Object (File)
Oct 23 2024, 7:06 AM
Unknown Object (File)
Oct 2 2024, 2:35 AM
Unknown Object (File)
Oct 2 2024, 2:07 AM
Unknown Object (File)
Oct 2 2024, 12:23 AM
Unknown Object (File)
Oct 1 2024, 9:35 PM
Unknown Object (File)
Oct 1 2024, 8:58 PM
Subscribers
None

Details

Summary

See PHI24. If you create a hosted Mercurial repository and switch it to observed, you can end up with a hook installed that runs on pulls and complains.

Instead, just bail out if we're running on a pull.

The corresponding Git hook doesn't run on pulls, so there's no issue in Git.

Test Plan

Executed the hook in an observed Mercurial repository, got a clean exit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable