Page MenuHomePhabricator

Treat commit hook execution in observed repositories as a no-op, not an error
ClosedPublic

Authored by epriestley on Jul 31 2017, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 17 2025, 1:49 AM
Unknown Object (File)
Apr 9 2025, 11:35 AM
Unknown Object (File)
Apr 8 2025, 9:24 PM
Unknown Object (File)
Apr 7 2025, 5:16 PM
Unknown Object (File)
Mar 25 2025, 6:35 AM
Unknown Object (File)
Mar 16 2025, 3:50 PM
Unknown Object (File)
Mar 12 2025, 8:35 AM
Unknown Object (File)
Feb 2 2025, 7:50 AM
Subscribers
None

Details

Summary

See PHI24. If you create a hosted Mercurial repository and switch it to observed, you can end up with a hook installed that runs on pulls and complains.

Instead, just bail out if we're running on a pull.

The corresponding Git hook doesn't run on pulls, so there's no issue in Git.

Test Plan

Executed the hook in an observed Mercurial repository, got a clean exit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable