Page MenuHomePhabricator

Censor credentials possibly present in Git remote URIs when pulls fail because of a URI mismatch
ClosedPublic

Authored by epriestley on Jul 31 2017, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Sun, Feb 9, 4:30 AM
Unknown Object (File)
Thu, Jan 30, 12:07 PM
Unknown Object (File)
Sun, Jan 26, 9:55 PM
Unknown Object (File)
Fri, Jan 24, 10:01 PM
Unknown Object (File)
Fri, Jan 24, 10:01 PM
Subscribers
None

Details

Summary

Fixes T12945.

Test Plan

Mostly faked this, got a censored error:

$ ./bin/repository update R38
[2017-07-31 19:40:13] EXCEPTION: (Exception) Working copy at "/Users/epriestley/dev/core/repo/local/38/" has a mismatched origin URI, "https://********@example.com/". The expected origin URI is "https://github.com/phacility/libphutil.git". Fix your configuration, or set the remote URI correctly. To avoid breaking anything, Phabricator will not automatically fix this. at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryEngine.php:186]

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable