Paths

Table of Contentst

Test 0 and "" cases in Project Icon Config
ClosedPublic
Actions

Authored by chad on Jul 10 2017, 6:41 PM.

Tags

None

Referenced Files

	F15581458: D18197.id43774.diff
	Wed, May 7, 11:06 AM

	F15561564: D18197.id.diff
	Tue, Apr 29, 8:50 PM

	F15554096: D18197.diff
	Mon, Apr 28, 5:26 AM

	F15539450: D18197.diff
	Fri, Apr 25, 1:37 AM

	F15457448: D18197.diff
	Mar 30 2025, 4:49 PM

	F15452253: D18197.id43773.diff
	Mar 29 2025, 3:22 AM

	F15440596: D18197.id.diff
	Mar 26 2025, 1:42 PM

	F15425996: D18197.id43773.diff
	Mar 23 2025, 6:48 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPaf71c990eee1: Test 0 and "" cases in Project Icon Config

Summary

Better validation for setting a default image in project.icon

Test Plan

Test adding "0" and "" as image options in project.icon, see error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jul 10 2017, 6:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 10 2017, 6:41 PM

Harbormaster completed remote builds in B17663: Diff 43773.Jul 10 2017, 6:42 PM

(The , null parameter has no effect for any input.)

This revision is now accepted and ready to land.Jul 10 2017, 6:57 PM

Closed by commit rPaf71c990eee1: Test 0 and "" cases in Project Icon Config (authored by chad, committed by chad). · Explain WhyJul 10 2017, 7:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

icon/

PhabricatorProjectIconSet.php

3 lines

Diff 43774

View Options

src/applications/project/icon/PhabricatorProjectIconSet.php

Test 0 and "" cases in Project Icon ConfigClosedPublicActions