Fix cancel button on inline comment view
ClosedPublic
Actions

Authored by chad on Jun 13 2017, 5:05 PM.

Tags

None

Referenced Files

	F18765960: D18120.id.diff
	Tue, Oct 7, 2:08 PM

	F18656921: D18120.diff
	Sep 22 2025, 11:51 PM

	F18468254: D18120.diff
	Sep 2 2025, 2:48 PM

	F18361071: D18120.id43594.diff
	Aug 27 2025, 11:22 AM

	F18360174: D18120.id.diff
	Aug 27 2025, 10:18 AM

	F18360129: D18120.id43601.diff
	Aug 27 2025, 10:11 AM

	F18360097: D18120.diff
	Aug 27 2025, 10:08 AM

	F18182350: D18120.id43601.diff
	Aug 16 2025, 9:17 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP21d16c723613: Fix cancel button on inline comment view

Summary

Switch over to PHUIButtonView

Test Plan

Cancel, Edit, Submit new inline diff comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jun 13 2017, 5:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 13 2017, 5:05 PM

Harbormaster completed remote builds in B17490: Diff 43594.Jun 13 2017, 5:06 PM

epriestley accepted this revision.Jun 13 2017, 8:39 PM

This revision is now accepted and ready to land.Jun 13 2017, 8:39 PM

Closed by commit rP21d16c723613: Fix cancel button on inline comment view (authored by chad, committed by chad). · Explain WhyJun 13 2017, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentEditView.php

15 lines

Diff 43601

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Fix cancel button on inline comment viewClosedPublicActions