Page MenuHomePhabricator
Differential D18088

Use normalsized font sizes in AphrontTable
ClosedPublic
Actions

Authored by chad on Jun 6 2017, 10:49 PM.
Tags
None
Referenced Files
F18053337: D18088.id43499.diff
Mon, Aug 4, 4:35 AM
F18052203: D18088.id43500.diff
Mon, Aug 4, 1:52 AM
F17868929: D18088.id.diff
Mon, Jul 28, 10:05 AM
F17859876: D18088.diff
Sun, Jul 27, 9:12 PM
Unknown Object (File)
May 31 2025, 10:58 AM
Unknown Object (File)
May 30 2025, 10:59 PM
Unknown Object (File)
May 30 2025, 8:04 AM
Unknown Object (File)
May 29 2025, 9:04 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPfd0cac0d459c: Use normalsized font sizes in AphrontTable
Summary

Updates to use the standard 13px size we use everywhere else, cleans up a few mobile/display bugs, adds a hover state for tr.

Test Plan

Review Diffusion, Daemons, Almanac, People Logs, anything else?

Screen Shot 2017-06-06 at 3.50.23 PM.png (2×3 px, 900 KB)

Screen Shot 2017-06-06 at 3.50.12 PM.png (2×3 px, 929 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Jun 6 2017, 10:49 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 6 2017, 10:49 PM
Harbormaster completed remote builds in B17411: Diff 43499.Jun 6 2017, 10:50 PM
chad edited the test plan for this revision. (Show Details)Jun 6 2017, 10:51 PM
epriestley accepted this revision.Jun 6 2017, 11:16 PM
This revision is now accepted and ready to land.Jun 6 2017, 11:16 PM
chad added a comment.Jun 6 2017, 11:19 PM

if the hover feels weird anywhere, lmk. I can add a noHover if needed, but it felt good generally in any table.

Closed by commit rPfd0cac0d459c: Use normalsized font sizes in AphrontTable (authored by chad, committed by chad). · Explain WhyJun 6 2017, 11:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
webroot/
rsrc/
css/
aphront/
26 lines
js/
application/
diffusion/
2 lines

Diff 43500

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
View Options

webroot/rsrc/js/application/diffusion/behavior-commit-graph.js

Loading...
Phabricator · Built by Phacility