Page MenuHomePhabricator

In commit history list view, show all commits
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:52 AM
Unknown Object (File)
Sun, Nov 24, 2:15 PM
Unknown Object (File)
Thu, Nov 21, 4:46 AM
Unknown Object (File)
Wed, Nov 20, 4:27 AM
Unknown Object (File)
Sat, Nov 16, 1:51 AM
Unknown Object (File)
Tue, Nov 12, 11:20 AM
Unknown Object (File)
Fri, Nov 8, 4:07 AM
Unknown Object (File)
Oct 22 2024, 3:28 PM
Subscribers
None

Details

Summary

Currently, the last group of commits is not shown in the list view because the final $list is never added to $view.

For example, if the first page would contain commits from "April 7", "April 6", and "April 5", commits from "April 5" are not shown.

(If a repository has 100 commits in a single day, nothing is shown.)

On this server, here's the bottom of page 1:

Screen Shot 2017-06-02 at 4.36.43 AM.png (1×1 px, 351 KB)

Here's the top of page 2:

Screen Shot 2017-06-02 at 4.36.47 AM.png (1×1 px, 354 KB)

However, here's git log between those commits:

$ git log --oneline 7e46^..5f49f
5f49f9c793 Add sound to logged out Conpherence
1644b45050 Disperse task subpriorities in blocks
c6a7bcfe89 Make Pholio description behave as a remarkup field (e.g., subscribe mentioned users)
bbc5f79227 Make membership lock/unlock feed stories read more naturally
789d57522b Make editing project images redirect to "Manage" more consistently
10b3879232 Make Project slug/hashtag transactions render a little more nicely
abd791889c Update Maniphest title transaction again
5a34b299e4 Update Maniphest title language
601622013d Clarify milestone/subproject creation language
c9889e3d55 Fix an issue in Phriction where moving a document just copied it instead
fdf00f6df4 Clean up some minor UI behaviors in Differential
6c46f27d98 Add quest objectives to the minimap
d783299a19 Fix Phriction status not set property on new document
93e28da76e Add more "disabled" UI to PHUIObjectItemView
7e46d7ab6a Migrate Project color to modular transactions

This group of commits does not currently appear anywhere in the list.

Test Plan

Viewed a page of commits, saw 100 commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 2 2017, 1:38 PM
This revision was automatically updated to reflect the committed changes.