Differential D18036

Fix lightbox circle icons
ClosedPublic
Actions

Authored by chad on May 27 2017, 12:25 AM.

Details

Reviewers

epriestley

Commits

rPd3b7a0f37c97: (stable) Fix lightbox circle icons
rPe5b3d0331974: Fix lightbox circle icons

Summary

These are unfortunatly manually built so I missed them in testing circle view changes.

Test Plan

Test lightbox, conpherence, uiexamples

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 27 2017, 12:25 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 27 2017, 12:25 AM

Harbormaster completed remote builds in B17295: Diff 43383.May 27 2017, 12:26 AM

epriestley accepted this revision.May 27 2017, 3:12 AM

This revision is now accepted and ready to land.May 27 2017, 3:12 AM

Closed by commit rPe5b3d0331974: Fix lightbox circle icons (authored by chad, committed by chad). · Explain WhyMay 27 2017, 3:13 AM

This revision was automatically updated to reflect the committed changes.

This fixes an actual UI issue in lightboxes, not just a UIExample or whatever, right (so I should cherry pick it)?

Yeah, it does this, which is minor, but a bug.

urgently hotfixing all computers in the world

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

24 lines

src/

view/

page/

PhabricatorStandardPageView.php

3 lines

webroot/

rsrc/

js/

core/

behavior-lightbox-attachments.js

4 lines

Diff 43387

View Options

resources/celerity/map.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Fix lightbox circle iconsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43387

resources/celerity/map.php

src/view/page/PhabricatorStandardPageView.php

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Fix lightbox circle icons
ClosedPublic
Actions

Revision Contents
Changeset List