Page MenuHomePhabricator

Hide inlines one-by-one, instead of in a big group

Authored by epriestley on May 9 2017, 9:01 PM.
Referenced Files
Unknown Object (File)
Fri, Aug 5, 5:20 PM
Unknown Object (File)
Wed, Aug 3, 10:54 PM
Unknown Object (File)
Wed, Aug 3, 8:52 AM
Unknown Object (File)
Wed, Jul 27, 6:46 AM
Unknown Object (File)
Mon, Jul 18, 10:23 AM
Unknown Object (File)
Thu, Jul 14, 9:45 AM
Unknown Object (File)
Jul 2 2022, 10:41 PM
Unknown Object (File)
Jul 2 2022, 10:41 PM



Ref T12616. Fixes T12153. Currently, when you hide inlines, they hide completely and turn into a little bubble on the previous line.

Instead, collapse them to a single line one-by-one. Narrowly, this fixes T12153.

In the future, I plan to make these changes so this feature makes more sense:

  • Introduce global "hide everything" states (T8909) so you can completely hide stuff if you want, and this represents more of a halfway state between "nuke it" and "view it".
  • Make the actual rendering better, so it says "epriestley: blah blah..." instead of just "..." -- and looks less dumb.

The real goal here is to introduce DiffInline and continue moving stuff from the tangled jungle of a million top-level behaviors to sensible smooth statefulness.

Test Plan
  • Hid and revealed inlines in unified and two-up modes.
  • These look pretty junk for now:

Screen Shot 2017-05-09 at 1.40.25 PM.png (333×925 px, 33 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

I'll hold this until a future change fixes the rendering (and likely until I find a complete path through the wilderness) since this is sort of borderline-unusable as-is, this was just a reasonable sort of checkpoint.

This revision is now accepted and ready to land.May 9 2017, 11:53 PM
This revision was automatically updated to reflect the committed changes.