Page MenuHomePhabricator

Update Legalpad to use modular transactions
ClosedPublic

Authored by chad on May 4 2017, 4:57 PM.
Tags
None
Referenced Files
F14036050: D17826.diff
Sun, Nov 10, 8:22 AM
F14028990: D17826.id42880.diff
Fri, Nov 8, 6:39 PM
F14021765: D17826.diff
Wed, Nov 6, 12:00 PM
F14011814: D17826.diff
Fri, Nov 1, 5:19 AM
F13990787: D17826.id.diff
Tue, Oct 22, 6:08 AM
F13974692: D17826.diff
Fri, Oct 18, 6:53 AM
Unknown Object (File)
Sep 22 2024, 2:45 PM
Unknown Object (File)
Sep 10 2024, 5:14 AM
Subscribers

Details

Summary

Update Legalpad for modular transactions

Test Plan
  • New Document (no sign)
  • New Document (individual)
  • New Document (corp)
  • Require Signature - get prompted to sign before I can do anything.
  • Edit Documents
  • Sign Documents
  • Comment on Documents

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/legalpad/editor/LegalpadDocumentEditor.php
30

Set a document you haven't signed to "Require signature to use Phabricator."

If the code works, you'll immediately be prompted to sign it.

The meaning here is "when a new document is configured to require a signature, invalidate the flag on all existing sessions so users have to sign it even if they were previously logged in with valid sessions".

src/applications/legalpad/storage/LegalpadTransaction.php
20–21

(Might not get called / be unnecessary?)

src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php
30

Word "document" probably reads awkwardly; remove?

This all looks fine, just kicking it back to your queue for that TODO.

This revision now requires changes to proceed.May 4 2017, 6:01 PM
chad edited edge metadata.
chad marked 3 inline comments as done.
  • move session destruction
This revision is now accepted and ready to land.May 4 2017, 7:32 PM
This revision was automatically updated to reflect the committed changes.