Page MenuHomePhabricator

Update Legalpad to use modular transactions
ClosedPublic

Authored by chad on May 4 2017, 4:57 PM.
Tags
None
Referenced Files
F19634134: D17826.id42882.diff
Thu, Feb 5, 7:49 AM
F19508399: D17826.id.diff
Sat, Jan 10, 4:09 AM
F18861520: D17826.diff
Nov 2 2025, 3:56 PM
F18805820: D17826.diff
Oct 18 2025, 4:38 PM
F18724193: D17826.diff
Sep 30 2025, 3:02 AM
F18595253: D17826.id42873.diff
Sep 12 2025, 9:01 PM
F18595057: D17826.id42880.diff
Sep 12 2025, 8:15 PM
F18568112: D17826.id42882.diff
Sep 9 2025, 10:50 PM
Subscribers

Details

Summary

Update Legalpad for modular transactions

Test Plan
  • New Document (no sign)
  • New Document (individual)
  • New Document (corp)
  • Require Signature - get prompted to sign before I can do anything.
  • Edit Documents
  • Sign Documents
  • Comment on Documents

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/legalpad/editor/LegalpadDocumentEditor.php
30

Set a document you haven't signed to "Require signature to use Phabricator."

If the code works, you'll immediately be prompted to sign it.

The meaning here is "when a new document is configured to require a signature, invalidate the flag on all existing sessions so users have to sign it even if they were previously logged in with valid sessions".

src/applications/legalpad/storage/LegalpadTransaction.php
20–21

(Might not get called / be unnecessary?)

src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php
30

Word "document" probably reads awkwardly; remove?

This all looks fine, just kicking it back to your queue for that TODO.

This revision now requires changes to proceed.May 4 2017, 6:01 PM
chad edited edge metadata.
chad marked 3 inline comments as done.
  • move session destruction
This revision is now accepted and ready to land.May 4 2017, 7:32 PM
This revision was automatically updated to reflect the committed changes.