Page MenuHomePhabricator

No-op the Conpherence thumbnail resizing migration
ClosedPublic

Authored by epriestley on Apr 23 2017, 11:42 AM.
Tags
None
Referenced Files
F14039662: D17770.id42733.diff
Mon, Nov 11, 6:07 AM
F14014607: D17770.id42733.diff
Sun, Nov 3, 6:21 AM
F14006518: D17770.id42733.diff
Mon, Oct 28, 11:41 AM
F14004960: D17770.id42733.diff
Sun, Oct 27, 6:06 AM
F13981183: D17770.id.diff
Sat, Oct 19, 2:47 PM
F13980545: D17770.id42733.diff
Sat, Oct 19, 11:22 AM
Unknown Object (File)
Oct 12 2024, 11:33 PM
Unknown Object (File)
Oct 2 2024, 1:44 AM
Subscribers
None

Details

Summary

Fixes T12628. After later changes to PhabricatorFile, this migration no longer runs if you upgrade through it to a recent HEAD while your data has some room images.

Since this isn't critical and has been available for ~6 months, I just nuked it as a first pass. I can find a more careful approach which lets us continue to run this migration instead if you're hesitant to skip this step, although it may be a little involved.

In 95% of cases we avoid this by updating the storage table as it existed at the time the migraiton ran, but Files are much too complicated for that to be realistic.

Test Plan

Ran bin/storage upgrade -f --apply phabricator:20161005.conpherence.image.2.php, saw it do nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

A slightly cleaner way to degrade this would be to copy the old profile image PHIDs to the new storage (so the images stick around, just without a resolution upgrade), but 20161016.conpherence.imagephids.sql deleted the old storage so writing and testing that patch is fairly involved: I'd have to install a copy from before Oct 2016, add images to rooms, then run the upgrade and verify that the low-resolution images survived the migration.

This revision is now accepted and ready to land.Apr 23 2017, 2:08 PM
This revision was automatically updated to reflect the committed changes.