Page MenuHomePhabricator

Fixes T4815
Needs ReviewPublic

Authored by fejnartal on Apr 20 2017, 9:58 PM.
Tags
None
Referenced Files
F15506875: D17749.diff
Tue, Apr 15, 2:42 PM
F15498184: D17749.id42692.diff
Sun, Apr 13, 12:11 PM
F15494885: D17749.id.diff
Sun, Apr 13, 1:59 AM
F15490490: D17749.diff
Fri, Apr 11, 5:55 PM
F15456326: D17749.id.diff
Mar 30 2025, 8:43 AM
F15415412: D17749.id.diff
Mar 20 2025, 5:50 AM
F15382207: D17749.diff
Mar 14 2025, 11:16 AM
F15376105: D17749.id42692.diff
Mar 13 2025, 1:44 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Replicated the class PHUIPagerView.php to implement a [Prev][Next] pager
with fixed pageSize=1 and surroundingPages=0.

I had to work around the fact that in Phriction the last version of a Document
can also be referenced as v=0.

This caused the pager to diplay the [Next] button with a link to version=1
when viewing the last version of a wiki Document.

Future improvements:
Currently, the first version of a Document displays the [Prev] button with a link
to the last version. I haven't found any elegant workaround to this behaviour, so I
have left it untouched.

This also causes wiki Documents with only 1 version to display the [Prev] button linked
to itself.

Test Plan

Visit any wiki page with more than 1 versions.
Navigate backward: always using the [Prev] button.
Navigate forward: always using the [Next] button.
Visit a wiki page with only 1 version.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16621
Build 22163: arc lint + arc unit