Page MenuHomePhabricator

Iterate over ranges correctly for encryped files
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:35 PM.
Tags
None
Referenced Files
F15335552: D17623.id42390.diff
Sat, Mar 8, 4:20 PM
F15326636: D17623.id42390.diff
Fri, Mar 7, 3:45 AM
Unknown Object (File)
Sat, Feb 22, 9:03 AM
Unknown Object (File)
Fri, Feb 21, 3:18 PM
Unknown Object (File)
Sun, Feb 16, 9:06 PM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Subscribers
None

Details

Summary

Fixes T12079. Currently, when a file is encrypted and a request has "Content-Range", we apply the range first, then decrypt the result. This doesn't work since you can't start decrypting something from somewhere in the middle (at least, not with our cipher selection).

Instead: decrypt the result, then apply the range.

Test Plan

Added failing unit tests, made them pass

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 5 2017, 4:35 PM
This revision was automatically updated to reflect the committed changes.