Page MenuHomePhabricator

Iterate over ranges correctly for encryped files
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:35 PM.
Tags
None
Referenced Files
F22211556: D17623.diff
Wed, Aug 26, 11:02 AM
Unknown Object (File)
Mon, Aug 24, 3:47 PM
Unknown Object (File)
Sat, Aug 22, 12:18 PM
Unknown Object (File)
Fri, Aug 14, 6:10 PM
Unknown Object (File)
Jun 30 2026, 12:55 PM
Unknown Object (File)
Jun 30 2026, 9:06 AM
Unknown Object (File)
Jun 28 2026, 7:58 AM
Unknown Object (File)
Jun 20 2026, 11:36 PM
Subscribers
None

Details

Summary

Fixes T12079. Currently, when a file is encrypted and a request has "Content-Range", we apply the range first, then decrypt the result. This doesn't work since you can't start decrypting something from somewhere in the middle (at least, not with our cipher selection).

Instead: decrypt the result, then apply the range.

Test Plan

Added failing unit tests, made them pass

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 5 2017, 4:35 PM
This revision was automatically updated to reflect the committed changes.