Page MenuHomePhabricator

Iterate over ranges correctly for encryped files
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:52 AM
Unknown Object (File)
Tue, Nov 19, 6:30 AM
Unknown Object (File)
Fri, Oct 25, 3:46 PM
Unknown Object (File)
Oct 22 2024, 6:19 PM
Unknown Object (File)
Oct 21 2024, 7:06 PM
Unknown Object (File)
Oct 14 2024, 10:29 AM
Unknown Object (File)
Oct 13 2024, 7:48 PM
Unknown Object (File)
Oct 13 2024, 11:29 AM
Subscribers
None

Details

Summary

Fixes T12079. Currently, when a file is encrypted and a request has "Content-Range", we apply the range first, then decrypt the result. This doesn't work since you can't start decrypting something from somewhere in the middle (at least, not with our cipher selection).

Instead: decrypt the result, then apply the range.

Test Plan

Added failing unit tests, made them pass

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 5 2017, 4:35 PM
This revision was automatically updated to reflect the committed changes.