Page MenuHomePhabricator

Deprecate "file.uploadhash"
ClosedPublic

Authored by epriestley on Apr 4 2017, 9:40 PM.
Tags
None
Referenced Files
F15511759: D17618.id42381.diff
Thu, Apr 17, 5:13 AM
F15473950: D17618.id42370.diff
Sun, Apr 6, 3:28 AM
F15447419: D17618.id42370.diff
Thu, Mar 27, 11:45 PM
F15439153: D17618.id42381.diff
Mar 26 2025, 6:02 AM
F15434276: D17618.id.diff
Mar 25 2025, 2:50 AM
F15433228: D17618.diff
Mar 24 2025, 10:09 PM
F15415741: D17618.id42381.diff
Mar 20 2025, 7:42 AM
F15412924: D17618.id42381.diff
Mar 19 2025, 3:47 PM
Subscribers
None

Details

Summary

Ref T12464. This is a very old method which let you create a file on the server by referring to data which already existed in another file.

Basically, long ago, arc could say "Do you already have a file with hash X?" and just skip some work if the server did.

arc has not called this method since D13017, in May 2015.

Since it's easy to do so, just make this method pretend that it never has the file. Very old clients will continue to work, since they would expect this response in the common case and continue by uploading data.

Test Plan
  • Grepped for uploadhash in Phabricator and Arcanist.
  • Called the method with the console, verified it returned null.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 4 2017, 10:30 PM
This revision was automatically updated to reflect the committed changes.