Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 9:07 AM
Unknown Object (File)
Fri, Feb 21, 3:16 PM
Unknown Object (File)
Thu, Feb 20, 11:49 AM
Unknown Object (File)
Sun, Feb 9, 3:37 AM
Unknown Object (File)
Sun, Feb 9, 3:37 AM
Unknown Object (File)
Sun, Feb 9, 3:37 AM
Unknown Object (File)
Sun, Feb 9, 3:37 AM
Unknown Object (File)
Feb 4 2025, 12:28 AM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.