Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F14790132: D17583.id42304.diff
Fri, Jan 24, 7:52 PM
F14790131: D17583.id42298.diff
Fri, Jan 24, 7:52 PM
F14790130: D17583.id.diff
Fri, Jan 24, 7:52 PM
F14790129: D17583.diff
Fri, Jan 24, 7:52 PM
Unknown Object (File)
Tue, Jan 21, 8:59 PM
Unknown Object (File)
Tue, Jan 21, 9:44 AM
Unknown Object (File)
Fri, Jan 17, 1:27 PM
Unknown Object (File)
Wed, Jan 1, 4:24 AM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.