Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F15414033: D17583.diff
Wed, Mar 19, 10:41 PM
F15397513: D17583.id.diff
Sun, Mar 16, 8:43 PM
F15381620: D17583.diff
Fri, Mar 14, 8:39 AM
Unknown Object (File)
Feb 27 2025, 9:07 AM
Unknown Object (File)
Feb 21 2025, 3:16 PM
Unknown Object (File)
Feb 20 2025, 11:49 AM
Unknown Object (File)
Feb 9 2025, 3:37 AM
Unknown Object (File)
Feb 9 2025, 3:37 AM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.