Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F13101373: D17583.id42304.diff
Fri, Apr 26, 11:35 PM
Unknown Object (File)
Mon, Apr 8, 10:29 AM
Unknown Object (File)
Fri, Mar 29, 3:51 AM
Unknown Object (File)
Mar 27 2024, 8:37 PM
Unknown Object (File)
Mar 21 2024, 6:35 AM
Unknown Object (File)
Feb 17 2024, 7:34 PM
Unknown Object (File)
Feb 17 2024, 6:36 PM
Unknown Object (File)
Feb 10 2024, 7:56 AM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.