Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F18820695: D17583.diff
Wed, Oct 22, 4:37 PM
F18689746: D17583.id42298.diff
Fri, Sep 26, 6:27 PM
F18679090: D17583.id.diff
Fri, Sep 26, 12:31 AM
F18647919: D17583.diff
Sep 19 2025, 3:11 PM
F18620451: D17583.diff
Sep 15 2025, 5:16 AM
F18470889: D17583.id.diff
Sep 2 2025, 6:36 PM
F18459730: D17583.diff
Sep 1 2025, 5:47 PM
F18459165: D17583.diff
Sep 1 2025, 4:26 PM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.