Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F17700695: D17583.diff
Tue, Jul 15, 9:01 PM
Unknown Object (File)
Jun 18 2025, 3:01 PM
Unknown Object (File)
May 29 2025, 9:12 AM
Unknown Object (File)
May 8 2025, 6:35 PM
Unknown Object (File)
May 8 2025, 3:24 PM
Unknown Object (File)
May 7 2025, 4:11 PM
Unknown Object (File)
May 2 2025, 5:53 AM
Unknown Object (File)
Mar 19 2025, 10:41 PM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.