Page MenuHomePhabricator

Soften a possible cluster search setup fatal
ClosedPublic

Authored by epriestley on Mar 28 2017, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 23, 8:05 PM
Unknown Object (File)
Apr 13 2017, 7:18 AM
Unknown Object (File)
Apr 10 2017, 11:34 AM
Unknown Object (File)
Apr 10 2017, 11:34 AM
Unknown Object (File)
Apr 10 2017, 11:34 AM
Unknown Object (File)
Apr 9 2017, 1:30 AM
Unknown Object (File)
Apr 4 2017, 11:17 PM
Unknown Object (File)
Mar 31 2017, 5:38 PM
Subscribers
None

Details

Summary

Ref T12450. The way that config repair and setup issues interact is kind of complicated, and if cluster.search is invalid we may end up using cluster.search before we repair it.

I poked at things for a bit but wasn't confident I could get it to consistently repair before we use it without doing a big messy change.

The only thing that really matters is whether "type" is valid or not, so just put a slightly softer/more-tailored check in for that.

Test Plan
  • With "type": "elastic", loaded setup issues.
  • Before patch: hard fatal.
  • After patch: softer fatal with more useful messaging.

Screen Shot 2017-03-28 at 3.11.24 PM.png (1×1 px, 247 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/infrastructure/cluster/config/PhabricatorClusterSearchConfigOptionType.php
7

Today is not my best day.

chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2017, 10:28 PM
This revision was automatically updated to reflect the committed changes.