Page MenuHomePhabricator

Clean up a few more daemon behaviors
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:44 PM.
Tags
None
Referenced Files
F15462663: D17560.id42230.diff
Tue, Apr 1, 4:34 PM
F15437781: D17560.id.diff
Tue, Mar 25, 9:25 PM
F15430691: D17560.diff
Mon, Mar 24, 8:35 AM
F15424789: D17560.diff
Sun, Mar 23, 12:19 AM
F15380514: D17560.diff
Mar 14 2025, 3:25 AM
Unknown Object (File)
Feb 25 2025, 5:14 PM
Unknown Object (File)
Feb 21 2025, 3:15 PM
Unknown Object (File)
Feb 18 2025, 2:43 AM
Subscribers
None

Details

Summary

Ref T12298.

  • If all daemons in all pools are hibernating already, we may exit immediately without sending EXIT events and fail to update the web UI.
  • A max() should be min() ("sleep for at most 180 seconds", not "sleep for at least 180 seconds").
  • If there are no daemons in a pool (unlikely/theoretical), we might not set the shutdown flag on the pool correctly.
  • An autoscale message may actually mean that a pool is exiting.
Test Plan
  • Ran bin/phd debug task, waited for daemon to hibernate, killed it, saw it vanish from daemon console.
  • Saw it hibernate for 60s, not 180s.
  • Uh, killed a pool real fast and nothing broke? This one is hard/impossible to test.
  • Read the newer autoscale message.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable