Page MenuHomePhabricator

Clean up a few more daemon behaviors
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:44 PM.
Tags
None
Referenced Files
F13179071: D17560.diff
Wed, May 8, 8:55 PM
Unknown Object (File)
Tue, May 7, 2:42 PM
Unknown Object (File)
Sat, May 4, 6:20 PM
Unknown Object (File)
Sat, Apr 27, 9:21 AM
Unknown Object (File)
Wed, Apr 24, 10:29 PM
Unknown Object (File)
Wed, Apr 24, 2:13 PM
Unknown Object (File)
Fri, Apr 19, 6:19 PM
Unknown Object (File)
Tue, Apr 9, 11:25 AM
Subscribers
None

Details

Summary

Ref T12298.

  • If all daemons in all pools are hibernating already, we may exit immediately without sending EXIT events and fail to update the web UI.
  • A max() should be min() ("sleep for at most 180 seconds", not "sleep for at least 180 seconds").
  • If there are no daemons in a pool (unlikely/theoretical), we might not set the shutdown flag on the pool correctly.
  • An autoscale message may actually mean that a pool is exiting.
Test Plan
  • Ran bin/phd debug task, waited for daemon to hibernate, killed it, saw it vanish from daemon console.
  • Saw it hibernate for 60s, not 180s.
  • Uh, killed a pool real fast and nothing broke? This one is hard/impossible to test.
  • Read the newer autoscale message.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable