Page MenuHomePhabricator

Send EXIT events more consistently from daemons
ClosedPublic

Authored by epriestley on Mar 24 2017, 3:56 PM.
Tags
None
Referenced Files
F14111148: D17553.diff
Wed, Nov 27, 8:27 PM
Unknown Object (File)
Sat, Nov 23, 1:52 AM
Unknown Object (File)
Wed, Nov 20, 7:36 PM
Unknown Object (File)
Fri, Nov 15, 8:52 PM
Unknown Object (File)
Tue, Nov 12, 2:12 AM
Unknown Object (File)
Fri, Nov 8, 7:35 PM
Unknown Object (File)
Fri, Nov 8, 7:35 PM
Unknown Object (File)
Fri, Nov 8, 9:05 AM
Subscribers
None

Details

Summary

Ref T12298. When we bin/phd restart daemons, we currently may miss sending EXIT events for daemons which aren't actively running at the time, since the EXIT event only happens when the subprocess exits, not if we tear down a waiting/sleeping/hibernating daemon.

The most common case of this is hibernating daemons. A less common case is daemons which have exited because of an error (usually, taskmasters).

In these cases, the web UI doesn't get cleaned up properly. Instead, send EXIT from any kind of teardown so we knock daemons out of the web UI more often.

Test Plan

Ran bin/phd restart a bunch, saw fewer hanging daemons in the web UI at /daemon/.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 24 2017, 4:06 PM
This revision was automatically updated to reflect the committed changes.