Page MenuHomePhabricator
Differential D17550

Improve daemon "waiting" message, config reload behavior
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 3:21 PM.
Tags
None
Referenced Files
F13088972: D17550.diff
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Fri, Apr 12, 1:15 PM
Unknown Object (File)
Thu, Apr 11, 9:21 AM
Unknown Object (File)
Sun, Apr 7, 10:46 PM
Unknown Object (File)
Feb 9 2024, 7:45 PM
Unknown Object (File)
Jan 24 2024, 4:39 AM
Unknown Object (File)
Jan 6 2024, 5:32 PM
Unknown Object (File)
Jan 6 2024, 11:08 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12298: Allow daemon pools to autoscale down to 0 processes
Commits
rPf13637627d65: Improve daemon "waiting" message, config reload behavior
Summary

Ref T12298. Two minor daemon improvements:

  • Make the "waiting" message reflect hibernation.
  • Don't trigger a reload right after launching.
Test Plan
  • Read "waiting" message.
  • Ran "bin/phd start", didn't see an immediate SIGHUP in the log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 24 2017, 3:21 PM
Harbormaster completed remote builds in B16123: Diff 42210.Mar 24 2017, 3:22 PM
chad accepted this revision.Mar 24 2017, 3:28 PM
This revision is now accepted and ready to land.Mar 24 2017, 3:28 PM
Closed by commit rPf13637627d65: Improve daemon "waiting" message, config reload behavior (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2017, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
controller/
10 lines
infrastructure/
daemon/
overseer/
6 lines

Diff 42212

View Options

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

Loading...
View Options

src/infrastructure/daemon/overseer/PhabricatorDaemonOverseerModule.php

Loading...
Phabricator · Built by Phacility