Differential D17550

Improve daemon "waiting" message, config reload behavior
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 3:21 PM.

Details

Reviewers

chad

Maniphest Tasks

T12298: Allow daemon pools to autoscale down to 0 processes

Commits

rPf13637627d65: Improve daemon "waiting" message, config reload behavior

Summary

Ref T12298. Two minor daemon improvements:

Make the "waiting" message reflect hibernation.
Don't trigger a reload right after launching.

Test Plan

Read "waiting" message.
Ran "bin/phd start", didn't see an immediate SIGHUP in the log.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 24 2017, 3:21 PM

Harbormaster completed remote builds in B16123: Diff 42210.Mar 24 2017, 3:22 PM

chad accepted this revision.Mar 24 2017, 3:28 PM

This revision is now accepted and ready to land.Mar 24 2017, 3:28 PM

Closed by commit rPf13637627d65: Improve daemon "waiting" message, config reload behavior (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2017, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

controller/

PhabricatorDaemonLogViewController.php

10 lines

infrastructure/

daemon/

overseer/

PhabricatorDaemonOverseerModule.php

6 lines

Diff 42212

View Options

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php