Page MenuHomePhabricator

Update puppet-lint format string to not use deprecated `linenumber`.
Needs ReviewPublic

Authored by oc243 on Mar 24 2017, 12:17 PM.
Tags
None
Referenced Files
F13088755: D17549.diff
Thu, Apr 25, 1:33 AM
Unknown Object (File)
Thu, Apr 11, 9:07 AM
Unknown Object (File)
Mar 23 2024, 9:14 AM
Unknown Object (File)
Mar 4 2024, 8:44 PM
Unknown Object (File)
Dec 23 2023, 2:38 AM
Unknown Object (File)
Nov 13 2023, 7:19 PM
Unknown Object (File)
Sep 8 2023, 11:28 PM
Unknown Object (File)
Sep 7 2023, 10:28 AM
Subscribers
This revision can not be accepted until the required legal agreements have been signed.

Details

Summary

puppet-lint's format string uses line rather than linenumber now to print
line numbers. Using linenumber causes an exception:

Some linters failed:
    - CommandException: Command failed with error #1!
      COMMAND
      'puppet-lint' '--error-level=all' '--log-format=%{linenumber}|%{column}|%{kind}|%{check}|%{message}' '/srv/fpp/srv/puppet/modules/fpp/manifests/jenkins.pp'

      STDOUT
      (empty)

      STDERR
      DEPRECATION: Please use %{line} instead of %{linenumber}
Test Plan

Tested on MacOS with puppet-lint v2.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 16122
Build 21393: arc lint + arc unit

Unit TestsFailed

TimeTest
1,736 msArcanistFlake8LinterTestCase::Unknown Unit Message ("")
In 'undefined.lint-test', expected lint to raise error on line 3 at char 1, but no error was raised. Actually raised: No messages.
28 msArcanistChmodLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
0 msArcanistClosureLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msArcanistCpplintLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
27 msArcanistFilenameLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
View Full Test Results (1 Failed · 30 Passed · 23 Skipped)

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.