Page MenuHomePhabricator

Update puppet-lint format string to not use deprecated `linenumber`.
Needs ReviewPublic

Authored by oc243 on Mar 24 2017, 12:17 PM.
Tags
None
Referenced Files
F15454865: D17549.id42209.diff
Sat, Mar 29, 8:55 PM
F15443710: D17549.diff
Thu, Mar 27, 5:47 AM
F15343442: D17549.diff
Mar 9 2025, 10:58 PM
Unknown Object (File)
Feb 9 2025, 3:33 AM
Unknown Object (File)
Jan 30 2025, 1:49 AM
Unknown Object (File)
Jan 24 2025, 7:47 PM
Unknown Object (File)
Jan 16 2025, 6:42 AM
Unknown Object (File)
Jan 15 2025, 7:35 PM
Subscribers
This revision can not be accepted until the required legal agreements have been signed.

Details

Summary

puppet-lint's format string uses line rather than linenumber now to print
line numbers. Using linenumber causes an exception:

Some linters failed:
    - CommandException: Command failed with error #1!
      COMMAND
      'puppet-lint' '--error-level=all' '--log-format=%{linenumber}|%{column}|%{kind}|%{check}|%{message}' '/srv/fpp/srv/puppet/modules/fpp/manifests/jenkins.pp'

      STDOUT
      (empty)

      STDERR
      DEPRECATION: Please use %{line} instead of %{linenumber}
Test Plan

Tested on MacOS with puppet-lint v2.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 16122
Build 21393: arc lint + arc unit

Unit TestsFailed

TimeTest
1,736 msArcanistFlake8LinterTestCase::Unknown Unit Message ("")
In 'undefined.lint-test', expected lint to raise error on line 3 at char 1, but no error was raised. Actually raised: No messages.
28 msArcanistChmodLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
0 msArcanistClosureLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msArcanistCpplintLinterTestCase::Unknown Unit Message ("")
1 assertion passed.
27 msArcanistFilenameLinterTestCase::Unknown Unit Message ("")
5 assertions passed.
View Full Test Results (1 Failed · 30 Passed · 23 Skipped)

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.