Page MenuHomePhabricator

Add a <reviewer, revision> key to the reviewers table
ClosedPublic

Authored by epriestley on Mar 22 2017, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:29 PM
Unknown Object (File)
Thu, Nov 14, 9:55 PM
Unknown Object (File)
Mon, Nov 11, 9:21 AM
Unknown Object (File)
Sun, Nov 10, 8:24 AM
Unknown Object (File)
Wed, Nov 6, 9:52 PM
Unknown Object (File)
Oct 19 2024, 10:00 AM
Unknown Object (File)
Oct 16 2024, 1:52 PM
Unknown Object (File)
Oct 11 2024, 4:02 AM
Subscribers
None

Details

Summary

Ref T10967. I'm not 100% sure we need this, but the old edge table had it and I recall an issue long ago where not having this key left us with a bad query plan.

Our data doesn't really provide a way to test this key (we have many revisions and few reviewers, so the query planner always uses revision keys), and building a convincing test case would take a while (lipsum needs some improvements to add reviewers). But in the worst case this key is mostly useless and wastes a few MB of disk space, which isn't a big deal.

So I can't conclusively prove that this key does anything to the dashboard query, but the migration removed it and I'm more comfortable keeping it so I'm not worried about breaking stuff.

At the very least, MySQL does select this key in the query plan when I do a "Reviewers:" query explicitly so it isn't useless.

Test Plan

Ran bin/storage upgrade, ran dashboard query, the query plan didn't get any worse.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 3:24 PM
This revision was automatically updated to reflect the committed changes.