Page MenuHomePhabricator

Remove obsolete "relationships" code from Differential
ClosedPublic

Authored by epriestley on Mar 20 2017, 9:10 PM.
Tags
None
Referenced Files
F19526971: D17518.id.diff
Sun, Jan 18, 9:41 PM
F19513767: D17518.id42142.diff
Tue, Jan 13, 5:09 PM
F19505610: D17518.diff
Fri, Jan 9, 1:00 PM
F19494630: D17518.diff
Thu, Jan 8, 9:51 AM
F18952500: D17518.diff
Nov 12 2025, 6:03 AM
F18938443: D17518.diff
Nov 11 2025, 3:45 AM
F18823544: D17518.diff
Oct 23 2025, 12:29 PM
F18810530: D17518.id.diff
Oct 19 2025, 10:02 PM
Subscribers
None

Details

Summary

Ref T10967. There have been two different ways to load reviewers for a while: needReviewerStatus() and needRelationships().

The needRelationships() stuff was a false start along time ago that didn't really go anywhere. I believe the idea was that we might want to load several different types of edges (subscribers, reviewers, etc) on lots of different types of objects. However, all that stuff pretty much ended up modularizing so that main Query classes did not need to know about it, so needRelationships() never got generalized or went anywhere.

A handful of things still use it, but get rid of them: they should either needReviewerStatus() to get reviewer info, or the ~3 callsites that care about subscribers can just load them directly.

Test Plan
  • Grepped for removed methods (needRelationships(), getReviewers(), getCCPHIDs(), etc).
  • Browsed Diffusion, Differential.
  • Called differential.query.

It's possible I missed some stuff, but it should mostly show up as super obvious fatals ("call needReviewerStatus() before getReviewerStatus()!").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 10:09 PM
This revision was automatically updated to reflect the committed changes.