Page MenuHomePhabricator

Use ModularTransactions for accept/reject/resign in "differential.createcomment"
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 30, 1:43 PM
Unknown Object (File)
Sun, Jun 29, 7:03 AM
Unknown Object (File)
Sat, Jun 28, 3:52 PM
Unknown Object (File)
May 31 2025, 3:05 AM
Unknown Object (File)
May 30 2025, 1:43 PM
Unknown Object (File)
May 28 2025, 10:35 AM
Unknown Object (File)
May 27 2025, 4:01 PM
Unknown Object (File)
May 10 2025, 9:55 AM
Subscribers
None

Details

Summary

Ref T10967. differential.createcomment is a frozen API method which has been obsoleted by differential.revision.edit.

It is the only remaining way to apply an "accept", "reject", or "resign" action using the old "ACTION" code.

Instead of using the old code, sneakly apply a new type of transaction in these cases instead.

Then, remove all the remaining old code for this stuff on the write pathways.

Test Plan
  • Used "differential.createcomment" to accept, reject, and resign from a revision.
  • Grepped for all removed ACTION_X constants, found them only in rendering code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable