Page MenuHomePhabricator

Use ModularTransactions for accept/reject/resign in "differential.createcomment"
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:37 PM.
Tags
None
Referenced Files
F15444027: D17513.id42138.diff
Thu, Mar 27, 7:25 AM
F15443239: D17513.id42122.diff
Thu, Mar 27, 3:14 AM
F15439801: D17513.id.diff
Wed, Mar 26, 9:32 AM
F15435040: D17513.id.diff
Tue, Mar 25, 6:37 AM
F15432283: D17513.diff
Mon, Mar 24, 5:16 PM
F15403871: D17513.id42122.diff
Tue, Mar 18, 5:14 AM
Unknown Object (File)
Feb 9 2025, 9:15 PM
Unknown Object (File)
Feb 9 2025, 3:29 AM
Subscribers
None

Details

Summary

Ref T10967. differential.createcomment is a frozen API method which has been obsoleted by differential.revision.edit.

It is the only remaining way to apply an "accept", "reject", or "resign" action using the old "ACTION" code.

Instead of using the old code, sneakly apply a new type of transaction in these cases instead.

Then, remove all the remaining old code for this stuff on the write pathways.

Test Plan
  • Used "differential.createcomment" to accept, reject, and resign from a revision.
  • Grepped for all removed ACTION_X constants, found them only in rendering code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable