Page MenuHomePhabricator

Use ModularTransactions for accept/reject/resign in "differential.createcomment"
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:37 PM.

Details

Summary

Ref T10967. differential.createcomment is a frozen API method which has been obsoleted by differential.revision.edit.

It is the only remaining way to apply an "accept", "reject", or "resign" action using the old "ACTION" code.

Instead of using the old code, sneakly apply a new type of transaction in these cases instead.

Then, remove all the remaining old code for this stuff on the write pathways.

Test Plan
  • Used "differential.createcomment" to accept, reject, and resign from a revision.
  • Grepped for all removed ACTION_X constants, found them only in rendering code.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 20 2017, 4:37 PM
chad accepted this revision.Mar 20 2017, 5:16 PM
This revision is now accepted and ready to land.Mar 20 2017, 5:16 PM
This revision was automatically updated to reflect the committed changes.