Attach commit data to commit list on people
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 12:44 AM.

Tags

None

Referenced Files

	F15483990: D17475.id42023.diff
	Wed, Apr 9, 3:35 PM

	F15483444: D17475.id42023.diff
	Wed, Apr 9, 12:16 PM

	F15480438: D17475.id42022.diff
	Tue, Apr 8, 2:06 PM

	F15479474: D17475.id.diff
	Tue, Apr 8, 7:33 AM

	F15477483: D17475.diff
	Mon, Apr 7, 3:16 PM

	F15434532: D17475.diff
	Mar 25 2025, 4:18 AM

	F15397626: D17475.id42022.diff
	Mar 16 2025, 9:24 PM

	F15282644: D17475.id.diff
	Mar 4 2025, 1:00 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12360: PhabricatorDataNotAttachedException on /people/commits/ID/

Commits

rP129483d5eac4: Attach commit data to commit list on people

Summary

Fixes T12360. I'll probably make a non-audit commit list for this, maybe, eventually, until then add all the needed audit information.

Test Plan

Review commits in my profile, see data and not a fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 7 2017, 12:44 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 12:44 AM

Harbormaster completed remote builds in B15928: Diff 42022.Mar 7 2017, 12:45 AM

epriestley accepted this revision.Mar 7 2017, 1:17 AM

This revision is now accepted and ready to land.Mar 7 2017, 1:17 AM

Closed by commit rP129483d5eac4: Attach commit data to commit list on people (authored by chad, committed by chad). · Explain WhyMar 7 2017, 1:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileCommitsController.php

3 lines

Diff 42023

View Options

src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php

Attach commit data to commit list on peopleClosedPublicActions