Attach commit data to commit list on people
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 12:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 4:20 PM

	Unknown Object (File)
	Fri, Dec 20, 5:37 PM

	Unknown Object (File)
	Fri, Dec 13, 9:27 PM

	Unknown Object (File)
	Thu, Dec 12, 5:51 AM

	Unknown Object (File)
	Sun, Dec 1, 1:33 PM

	Unknown Object (File)
	Mon, Nov 25, 4:56 AM

	Unknown Object (File)
	Sat, Nov 23, 8:33 PM

	Unknown Object (File)
	Nov 21 2024, 12:37 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12360: PhabricatorDataNotAttachedException on /people/commits/ID/

Commits

rP129483d5eac4: Attach commit data to commit list on people

Summary

Fixes T12360. I'll probably make a non-audit commit list for this, maybe, eventually, until then add all the needed audit information.

Test Plan

Review commits in my profile, see data and not a fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 7 2017, 12:44 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 12:44 AM

Harbormaster completed remote builds in B15928: Diff 42022.Mar 7 2017, 12:45 AM

epriestley accepted this revision.Mar 7 2017, 1:17 AM

This revision is now accepted and ready to land.Mar 7 2017, 1:17 AM

Closed by commit rP129483d5eac4: Attach commit data to commit list on people (authored by chad, committed by chad). · Explain WhyMar 7 2017, 1:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileCommitsController.php

3 lines

Diff 42023

View Options

src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php

Attach commit data to commit list on peopleClosedPublicActions