Page MenuHomePhabricator

Auto-generate profile images for sad psyducks
ClosedPublic

Authored by chad on Mar 5 2017, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 5:39 PM
Unknown Object (File)
Mon, Mar 4, 6:55 AM
Unknown Object (File)
Feb 24 2024, 5:05 PM
Unknown Object (File)
Feb 9 2024, 10:08 AM
Unknown Object (File)
Feb 4 2024, 11:41 PM
Unknown Object (File)
Feb 3 2024, 3:01 PM
Unknown Object (File)
Jan 29 2024, 1:18 AM
Unknown Object (File)
Jan 1 2024, 5:06 AM
Subscribers

Details

Summary

Fixes T10319. This looks for custom profile image, then falls back to a generated profile image.

Test Plan

Create a new user, log in, and see new profile image. Note this seems to break bin/lipsum generate user

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/people/storage/PhabricatorUserProfile.php
17–18

I AM SURE THIS IS WRONG

  • clean up peopleprofilepicturecontroller
epriestley added inline comments.
src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
40

This means we'll auto-upgrade to v2 when users load pages, but not when users run bin/people profileimage, I think? I think either "auto-upgrade" or "no auto-upgrade" are reasonable, but we should probably make both the script and cache do the same thing unless there's some particular reason not to.

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
90–93

It's possible this query could miss (if someone ran bin/remove destroy on the File, for example), so it would cover slightly more cases to do this:

if ($default_image) {
  $default_image = load file;
}

if (!$default_image) { // <-- instead of "else"
  $default_image = psyduck;
}
src/applications/people/storage/PhabricatorUserProfile.php
17–18

NOPE IT'S CORRECT SORRY BUDDY YOU DID A GREAT JOB

This revision is now accepted and ready to land.Mar 5 2017, 10:20 AM
chad marked 2 inline comments as done.Mar 5 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.